linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] versatile: don't generate a duplicate IRQ domain
Date: Thu, 12 Jan 2012 21:58:01 +0000	[thread overview]
Message-ID: <20120112215801.GB13991@page> (raw)
In-Reply-To: <20120112203756.GM1068@n2100.arm.linux.org.uk>

Hi Russell,

On Thu, Jan 12, 2012 at 08:37:56PM +0000, Russell King - ARM Linux wrote:
> On Fri, Jan 06, 2012 at 04:39:57PM +0000, Jamie Iles wrote:
> > Now that the VIC driver handles the irqdomain natively we don't need to
> > generate one in the versatile core code.  Longer term we should move the
> > initialisation of both IRQ controllers to using of_irq_init() but
> > that'll need a little more work.
> > 
> > Cc: Russell King <linux@arm.linux.org.uk>
> > Cc: Grant Likely <grant.likely@secretlab.ca>
> > Signed-off-by: Jamie Iles <jamie@jamieiles.com>
> 
> Please confirm that this patch can be applied ontop of commit
> 356b95424cfb456e14a59eaa579422ce014c424b
> (Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k)

OK, this does apply, but it doesn't fail in the way I had expected.  
Actually, it doesn't barf at all because the generated domain that my 
patch removes has 0 IRQ's so it never gets attached to the irq_desc's.

However, this patch is still valid as we end up with two domains 
associated with the VIC but we get lucky as the real domain is 
registered first.  I can update the patch description to reflect this if 
you still want to apply it.

Incidentally, I've managed to get the versatile kernel booting under 
qemu (using an experimental build with DT support, up to trying to mount 
a rootfs), which seems to work nicely.  I just need to find a suitable 
rootfs and that'll be a nice test system.

Jamie

  reply	other threads:[~2012-01-12 21:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-06 16:39 [PATCH] versatile: don't generate a duplicate IRQ domain Jamie Iles
2012-01-12 20:37 ` Russell King - ARM Linux
2012-01-12 21:58   ` Jamie Iles [this message]
2012-01-12 22:14     ` Russell King - ARM Linux
2012-01-12 23:07       ` Grant Likely
2012-01-12 23:18         ` Russell King - ARM Linux
2012-01-12 23:26           ` Jamie Iles
2012-01-12 23:28             ` Russell King - ARM Linux
2012-01-12 23:30               ` Jamie Iles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120112215801.GB13991@page \
    --to=jamie@jamieiles.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).