From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux@arm.linux.org.uk (Russell King - ARM Linux) Date: Thu, 12 Jan 2012 22:14:54 +0000 Subject: [PATCH] versatile: don't generate a duplicate IRQ domain In-Reply-To: <20120112215801.GB13991@page> References: <1325867997-20761-1-git-send-email-jamie@jamieiles.com> <20120112203756.GM1068@n2100.arm.linux.org.uk> <20120112215801.GB13991@page> Message-ID: <20120112221454.GN1068@n2100.arm.linux.org.uk> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, Jan 12, 2012 at 09:58:01PM +0000, Jamie Iles wrote: > Hi Russell, > > On Thu, Jan 12, 2012 at 08:37:56PM +0000, Russell King - ARM Linux wrote: > > On Fri, Jan 06, 2012 at 04:39:57PM +0000, Jamie Iles wrote: > > > Now that the VIC driver handles the irqdomain natively we don't need to > > > generate one in the versatile core code. Longer term we should move the > > > initialisation of both IRQ controllers to using of_irq_init() but > > > that'll need a little more work. > > > > > > Cc: Russell King > > > Cc: Grant Likely > > > Signed-off-by: Jamie Iles > > > > Please confirm that this patch can be applied ontop of commit > > 356b95424cfb456e14a59eaa579422ce014c424b > > (Merge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/geert/linux-m68k) > > OK, this does apply, but it doesn't fail in the way I had expected. > Actually, it doesn't barf at all because the generated domain that my > patch removes has 0 IRQ's so it never gets attached to the irq_desc's. If you say... > However, this patch is still valid as we end up with two domains > associated with the VIC but we get lucky as the real domain is > registered first. I can update the patch description to reflect this if > you still want to apply it. If you think the patch comments don't reflect what the patch is doing then yes please. I don't know how this irq domain stuff works so I really can't say anything much about this patch other than trust you that it's correct.