From mboxrd@z Thu Jan 1 00:00:00 1970 From: tony@atomide.com (Tony Lindgren) Date: Fri, 13 Jan 2012 08:44:59 -0800 Subject: [PATCH] arm: omap4: Fix omap_barriers_init for generic ioremap changes In-Reply-To: <20120113150421.GF16726@n2100.arm.linux.org.uk> References: <20120112184256.GA2287@atomide.com> <20120112195951.GB2287@atomide.com> <20120113140520.GE16726@n2100.arm.linux.org.uk> <20120113150421.GF16726@n2100.arm.linux.org.uk> Message-ID: <20120113164459.GI15299@atomide.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org * Russell King - ARM Linux [120113 06:31]: > On Fri, Jan 13, 2012 at 02:05:20PM +0000, Russell King - ARM Linux wrote: > > From: Russell King > > ARM: Add arm_memblock_steal() to allocate memory away from the kernel > > > > Several platforms are now using the memblock_alloc+memblock_free+ > > memblock_remove trick to obtain memory which won't be mapped in the > > kernel's page tables. Most platforms do this (correctly) in the > > ->reserve callback. However, OMAP has started to call these functions > > outside of this callback, and this is extremely unsafe - memory will > > not be unmapped, and could well be given out after memblock is no > > longer responsible for its management. > > > > So, provide arm_memblock_steal() to perform this function, and ensure > > that it panic()s if it is used inappropriately. Convert everyone > > over, including OMAP. > > > > As a result, OMAP will panic on boot with this change. OMAP needs to > > be fixed, or 137d105d50 (ARM: OMAP4: Fix errata i688 with MPU > > interconnect barriers.) reverted until such time it can be fixed > > correctly. > > Santosh points out that this is only used if the errata i688 option is > enabled, so I've added to this patch to make this config option depend > on BROKEN, marked it as such, and commited the result to my fixes branch. > > I'll be planning to push this to Linus sometime on Monday. Sounds good to me. Thanks, Tony