From mboxrd@z Thu Jan 1 00:00:00 1970 From: will.deacon@arm.com (Will Deacon) Date: Fri, 13 Jan 2012 18:14:22 +0000 Subject: [PATCH 1/2] mach-ux500: cache operations are atomic on PL310 In-Reply-To: <1326346663-6112-1-git-send-email-srinidhi.kasagar@stericsson.com> References: <1326346663-6112-1-git-send-email-srinidhi.kasagar@stericsson.com> Message-ID: <20120113181422.GB24373@mudshark.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi guys, On Thu, Jan 12, 2012 at 05:37:42AM +0000, Srinidhi KASAGAR wrote: > Apply ERRATA_753970 for ux500 variant of cache sync too > > Signed-off-by: srinidhi kasagar > Acked-by: Linus Walleij > --- > arch/arm/mach-ux500/cache-l2x0.c | 11 ++++++++--- > 1 files changed, 8 insertions(+), 3 deletions(-) I hadn't noticed the existence of this file before, but this patch really shows why it's not a good idea to copy files out of core ARM code and into the mach-* directories. I see that the commit introducing this file 458eef2f ("mach-ux500: factor out l2x0 handling code") mentions that mach-imx does the same thing, but I can't find the code there. On top of that, it seems as though you provide an inv_all implementation but your disable function is empty. Surely this can lead to data loss? Will