From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mx53_loco: add DA9053 PMIC support
Date: Mon, 16 Jan 2012 23:00:19 +0000 [thread overview]
Message-ID: <20120116230019.GF32049@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1326733853-13956-2-git-send-email-paul.liu@linaro.org>
On Tue, Jan 17, 2012 at 01:10:53AM +0800, Ying-Chun Liu (PaulLiu) wrote:
> diff --git a/arch/arm/mach-mx5/board-mx53_loco.c b/arch/arm/mach-mx5/board-mx53_loco.c
> index fd8b524..61dd8c9 100644
> --- a/arch/arm/mach-mx5/board-mx53_loco.c
> +++ b/arch/arm/mach-mx5/board-mx53_loco.c
> @@ -23,10 +23,21 @@
> #include <linux/delay.h>
> #include <linux/gpio.h>
You have this ^^^^^^^ include, which includes asm/gpio.h, and in turn
mach/gpio.h, but...
> #include <linux/i2c.h>
> +#include <linux/module.h>
> +#include <linux/platform_device.h>
> +#include <linux/irq.h>
> +#include <linux/interrupt.h>
> +#include <linux/err.h>
> +#include <linux/regulator/machine.h>
> +#include <linux/regulator/fixed.h>
> +#include <linux/mfd/da9052/da9052.h>
> +#include <linux/mfd/da9052/pdata.h>
>
> #include <mach/common.h>
> #include <mach/hardware.h>
> #include <mach/iomux-mx53.h>
> +#include <mach/irqs.h>
> +#include <mach/gpio.h>
you include mach/gpio.h here? I don't see why you need mach/irqs.h
either.
That brings into this another question: you're adding 9 new linux/
includes above. How many of those do you _actually_ need? Eg, I
don't see you adding anything from linux/err.h to this file, so why
do you need this header?
Please don't add include files unnecessarily.
prev parent reply other threads:[~2012-01-16 23:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-16 17:10 [PATCH] mx53_loco: add DA9053 PMIC support Ying-Chun Liu (PaulLiu)
2012-01-16 17:10 ` Ying-Chun Liu (PaulLiu)
2012-01-16 19:19 ` Mark Brown
2012-01-16 21:08 ` Arnaud Patard (Rtp)
2012-01-17 18:45 ` Ying-Chun Liu (PaulLiu)
2012-01-16 23:00 ` Russell King - ARM Linux [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120116230019.GF32049@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).