linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] mfd: mc13xxx-core: Move spi specific code into separate module.
Date: Thu, 19 Jan 2012 05:54:39 -0700	[thread overview]
Message-ID: <20120119125439.GR4223@ponder.secretlab.ca> (raw)
In-Reply-To: <20120119080843.GC4066@pengutronix.de>

On Thu, Jan 19, 2012 at 09:08:43AM +0100, Uwe Kleine-K?nig wrote:
> Hello,
> 
> On Thu, Jan 19, 2012 at 12:01:33PM +1100, Marc Reilly wrote:
> > All spi specific code is moved into a new module. The mc13xxx
> > struct moves to the include file by necessity.
> > 
> > A new config choice selects the bus type with SPI as the first item
> > (default selection) to remain compatible with existing configs.
> > 
> > Signed-off-by: Marc Reilly <marc@cpdesign.com.au>
> > ---
> > +choice
> > +	tristate "MC13XXX Bus interface type"
> > +	depends on MFD_MC13XXX
> > +	default MFD_MC13XXX_SPI
> > +	help
> > +	  The MC13XXX family can be connected over an SPI or I2C bus.
> > +	  Select the appropriate option for your hardware configuration.
> > +
> > +config MFD_MC13XXX_SPI
> > +	tristate "SPI interface"
> > +	depends on SPI_MASTER
> > +	help
> > +	  Select this if your MC13xxx is connected via an SPI bus.
> > +
> > +endchoice
> > +
> Hmm, you cannot have both, spi and i2c support?

+1 on Uwe's comment.  We're going multiplatform.  I2C and SPI support
should not be mutually exclusive.

g.

  reply	other threads:[~2012-01-19 12:54 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19  1:01 mc13xxx: add I2C support Marc Reilly
2012-01-19  1:01 ` [PATCH 1/3] mc13xxx-core: Prepare for separate spi and i2c backends Marc Reilly
2012-01-19  7:35   ` Shawn Guo
2012-01-19  7:51   ` Uwe Kleine-König
2012-01-19  1:01 ` [PATCH 2/3] mfd: mc13xxx-core: Move spi specific code into separate module Marc Reilly
2012-01-19  8:08   ` Uwe Kleine-König
2012-01-19 12:54     ` Grant Likely [this message]
2012-01-19  1:01 ` [PATCH 3/3] mfd: mc13xxx-core: Add i2c driver Marc Reilly
2012-01-19  7:22 ` mc13xxx: add I2C support Shawn Guo
2012-01-19 11:12 ` Arnaud Patard (Rtp)
2012-01-19 11:29   ` Mark Brown
     [not found]     ` <201201201855.35971.marc@cpdesign.com.au>
2012-01-20 10:36       ` Arnaud Patard (Rtp)
2012-01-20 12:08       ` Mark Brown
2012-02-20 16:50       ` Samuel Ortiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120119125439.GR4223@ponder.secretlab.ca \
    --to=grant.likely@secretlab.ca \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).