From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] S3C24XX DMA resume regression fix
Date: Fri, 20 Jan 2012 12:14:02 +0000 [thread overview]
Message-ID: <20120120121402.GM1068@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120120114902.GB22732@build.ihdev.net>
On Fri, Jan 20, 2012 at 06:49:02AM -0500, Sergey Lapin wrote:
> On Sun, Jan 15, 2012 at 01:52:17AM +0400, Sergei Shtylyov wrote:
> > Hello.
> >
> > On 13-01-2012 17:47, Gusakov Andrey wrote:
> >
> > >In commit bb072c3cf21d1c9a5a2eeb5a00679ee7bf39675b suspend/resume
> >
> > Please also specify that commit's summary in parens.
>
> Could you please point me in direction of patch submission
> guide where that is explained.
It's something that's been asked for by Linus - and as Linus can refuse
to pull anything he doesn't like, it's something that we'd better satisfy
if we want patches to hit mainline.
Like everything in kernel development, what's written in documentation is
never the full story; things change through discussions on mailing lists,
new guidelines get created, and the documents become stale. That's the
nature of this.
Anyone is free to update the documentation, so if you think it's got a
shortcoming, please feel free to send a documentation patch.
> The commit message summary is
> ARM / Samsung: Use struct syscore_ops for "core" power management
>
> But that is not revert of that commit, so I don't really
> see a point. This is bug fix which fixes resume code path.
The point is that if you include a commit ID, then you should include
the summary, so people reading the commit message don't have to faff
around trying to find out what you're referring to.
See, for example, http://lkml.org/lkml/2010/6/1/498
next prev parent reply other threads:[~2012-01-20 12:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-13 13:47 [PATCH] S3C24XX DMA resume regression fix Gusakov Andrey
2012-01-14 21:52 ` Sergei Shtylyov
2012-01-20 11:49 ` Sergey Lapin
2012-01-20 12:14 ` Russell King - ARM Linux [this message]
2012-01-20 13:26 ` Sergey Lapin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120120121402.GM1068@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).