From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 05/31] ARM: amba: mxs: convert to use amba_device_alloc
Date: Fri, 20 Jan 2012 12:39:23 +0000 [thread overview]
Message-ID: <20120120123923.GP16726@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120120122535.GA25917@S2101-09.ap.freescale.net>
On Fri, Jan 20, 2012 at 08:25:39PM +0800, Shawn Guo wrote:
> On Fri, Jan 20, 2012 at 09:24:05AM +0000, Russell King - ARM Linux wrote:
> > Convert MXS to use the new amba_device_alloc APIs.
> >
> > Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > ---
> > arch/arm/mach-mxs/devices.c | 8 +++++---
> > 1 files changed, 5 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/arm/mach-mxs/devices.c b/arch/arm/mach-mxs/devices.c
> > index fe3e847..052d8dd 100644
> > --- a/arch/arm/mach-mxs/devices.c
> > +++ b/arch/arm/mach-mxs/devices.c
> > @@ -77,16 +77,18 @@ struct platform_device *__init mxs_add_platform_device_dmamask(
> >
> > int __init mxs_add_amba_device(const struct amba_device *dev)
> > {
> > - struct amba_device *adev = kmalloc(sizeof(*adev), GFP_KERNEL);
> > + struct amba_device *adev = amba_device_alloc(dev->init_name,
>
> The 'dev->init_name' needs to be 'dev->dev.init_name'. Otherwise, we
> see the compile error below.
Good catch, fixed, and ack added, thanks.
next prev parent reply other threads:[~2012-01-20 12:39 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-20 9:22 [PATCH 00/31] Clean up amba/primecell bus support Russell King - ARM Linux
2012-01-20 9:22 ` [PATCH 01/31] ARM: amba: add amba_device allocation/add/put functions Russell King - ARM Linux
2012-01-20 9:23 ` [PATCH 02/31] ARM: amba: of: convert to use amba_device_alloc Russell King - ARM Linux
2012-01-20 13:58 ` Rob Herring
2012-01-20 9:23 ` [PATCH 03/31] ARM: amba: ux500: " Russell King - ARM Linux
2012-01-21 16:21 ` Srinidhi KASAGAR
2012-01-23 19:03 ` Linus Walleij
2012-01-20 9:23 ` [PATCH 04/31] ARM: amba: integrator: " Russell King - ARM Linux
2012-01-20 9:24 ` [PATCH 05/31] ARM: amba: mxs: " Russell King - ARM Linux
2012-01-20 12:25 ` Shawn Guo
2012-01-20 12:39 ` Russell King - ARM Linux [this message]
2012-01-20 9:24 ` [PATCH 06/31] ARM: amba: make irq 0 invalid Russell King - ARM Linux
2012-01-20 9:24 ` [PATCH 07/31] ARM: amba: ux500: get rid of NO_IRQ Russell King - ARM Linux
2012-01-21 16:19 ` Srinidhi KASAGAR
2012-01-23 19:04 ` Linus Walleij
2012-01-20 9:25 ` [PATCH 08/31] ARM: amba: get rid of NO_IRQ initializers Russell King - ARM Linux
2012-01-20 9:25 ` [PATCH 09/31] ARM: amba: samsung: " Russell King - ARM Linux
2012-01-21 0:28 ` Kukjin Kim
2012-01-20 9:25 ` [PATCH 10/31] ARM: amba: integrator/realview/versatile/vexpress: " Russell King - ARM Linux
2012-01-20 9:26 ` [PATCH 11/31] ARM: amba: lpc32xx: " Russell King - ARM Linux
2012-01-20 9:26 ` [PATCH 12/31] ARM: amba: mxs: " Russell King - ARM Linux
2012-01-20 12:27 ` Shawn Guo
2012-01-20 9:26 ` [PATCH 13/31] ARM: amba: nomadik: " Russell King - ARM Linux
2012-01-23 19:02 ` Linus Walleij
2012-01-20 9:27 ` [PATCH 14/31] ARM: amba: netx: " Russell King - ARM Linux
2012-01-20 9:27 ` [PATCH 15/31] ARM: amba: spear: " Russell King - ARM Linux
2012-01-20 9:30 ` Viresh Kumar
2012-01-20 9:27 ` [PATCH 16/31] ARM: amba: u300: " Russell King - ARM Linux
2012-01-23 19:04 ` Linus Walleij
2012-01-20 9:28 ` [PATCH 17/31] ARM: amba: make use of -1 IRQs warn Russell King - ARM Linux
2012-01-20 9:28 ` [PATCH 18/31] ARM: amba: provide common initializers for static amba devices Russell King - ARM Linux
2012-01-20 17:58 ` H Hartley Sweeten
2012-01-20 9:28 ` [PATCH 19/31] ARM: amba: vexpress: get rid of private platform amba_device initializer Russell King - ARM Linux
2012-01-24 14:27 ` Will Deacon
2012-01-20 9:29 ` [PATCH 20/31] ARM: amba: versatile: " Russell King - ARM Linux
2012-01-24 15:06 ` Will Deacon
2012-01-20 9:29 ` [PATCH 21/31] ARM: amba: realview: " Russell King - ARM Linux
2012-01-24 16:00 ` Will Deacon
2012-01-24 16:23 ` Russell King - ARM Linux
2012-01-24 17:26 ` Will Deacon
2012-01-24 21:23 ` Linus Walleij
2012-01-24 21:45 ` Russell King - ARM Linux
2012-01-25 9:58 ` Will Deacon
2012-01-25 10:22 ` Russell King - ARM Linux
2012-01-25 10:39 ` Will Deacon
2012-01-25 11:06 ` Russell King - ARM Linux
2012-01-26 17:25 ` Russell King - ARM Linux
2012-01-26 17:37 ` Will Deacon
2012-01-26 17:41 ` Russell King - ARM Linux
2012-01-20 9:29 ` [PATCH 22/31] ARM: amba: integrator: use common amba device initializers Russell King - ARM Linux
2012-01-24 16:13 ` Will Deacon
2012-01-20 9:30 ` [PATCH 23/31] ARM: amba: omap2: " Russell King - ARM Linux
2012-01-20 14:37 ` Tony Lindgren
2012-01-20 9:30 ` [PATCH 24/31] ARM: amba: ep93xx: " Russell King - ARM Linux
2012-01-20 16:56 ` H Hartley Sweeten
2012-01-20 9:30 ` [PATCH 25/31] ARM: amba: bcmring: " Russell King - ARM Linux
2012-01-20 9:31 ` [PATCH 26/31] ARM: amba: netx: " Russell King - ARM Linux
2012-01-20 9:31 ` [PATCH 27/31] ARM: amba: lpc32xx: " Russell King - ARM Linux
2012-01-20 9:31 ` [PATCH 28/31] ARM: amba: u300: " Russell King - ARM Linux
2012-01-23 19:05 ` Linus Walleij
2012-01-20 9:32 ` [PATCH 29/31] ARM: amba: nomadik: " Russell King - ARM Linux
2012-01-23 19:02 ` Linus Walleij
2012-01-20 9:32 ` [PATCH 30/31] ARM: amba: spear: " Russell King - ARM Linux
2012-01-20 9:38 ` Viresh Kumar
2012-01-20 9:32 ` [PATCH 31/31] ARM: amba: samsung: " Russell King - ARM Linux
2012-01-21 0:45 ` Kukjin Kim
2012-01-20 22:33 ` [PATCH 13/31] ARM: amba: nomadik: get rid of NO_IRQ initializers Alessandro Rubini
2012-01-20 22:33 ` [PATCH 29/31] ARM: amba: nomadik: use common amba device initializers Alessandro Rubini
2012-01-21 0:59 ` [PATCH 00/31] Clean up amba/primecell bus support Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120120123923.GP16726@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).