linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: kristoffer.ericson@gmail.com (Kristoffer Ericson)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mach-sa1100: add missing module_init() call
Date: Sat, 21 Jan 2012 11:50:20 +0100	[thread overview]
Message-ID: <20120121105020.GA22705@Boggieman> (raw)
In-Reply-To: <1326998362-7630-1-git-send-email-linus.walleij@linaro.org>

On Thu, Jan 19, 2012 at 07:39:22PM +0100, Linus Walleij wrote:
> The Jornada SSP driver is supposed to be initialized by a
> module_init() call, but it was missed at some merge point. Since
> the driver mostly pass calls through it magically works anyway,
> but needs to be rectified.
> 
> Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

Thanks for spotting this :)

Acked-by: Kristoffer Ericson <kristoffer.ericson@gmail.com> 

> ---
>  arch/arm/mach-sa1100/jornada720_ssp.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-sa1100/jornada720_ssp.c b/arch/arm/mach-sa1100/jornada720_ssp.c
> index f50b00b..b412fc0 100644
> --- a/arch/arm/mach-sa1100/jornada720_ssp.c
> +++ b/arch/arm/mach-sa1100/jornada720_ssp.c
> @@ -198,3 +198,5 @@ static int __init jornada_ssp_init(void)
>  {
>  	return platform_driver_register(&jornadassp_driver);
>  }
> +
> +module_init(jornada_ssp_init);
> -- 
> 1.7.7.5

      reply	other threads:[~2012-01-21 10:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-19 18:39 [PATCH] mach-sa1100: add missing module_init() call Linus Walleij
2012-01-21 10:50 ` Kristoffer Ericson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120121105020.GA22705@Boggieman \
    --to=kristoffer.ericson@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).