* [PATCH] mach-sa1100: add missing module_init() call
@ 2012-01-19 18:39 Linus Walleij
2012-01-21 10:50 ` Kristoffer Ericson
0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2012-01-19 18:39 UTC (permalink / raw)
To: linux-arm-kernel
The Jornada SSP driver is supposed to be initialized by a
module_init() call, but it was missed at some merge point. Since
the driver mostly pass calls through it magically works anyway,
but needs to be rectified.
Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
arch/arm/mach-sa1100/jornada720_ssp.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-sa1100/jornada720_ssp.c b/arch/arm/mach-sa1100/jornada720_ssp.c
index f50b00b..b412fc0 100644
--- a/arch/arm/mach-sa1100/jornada720_ssp.c
+++ b/arch/arm/mach-sa1100/jornada720_ssp.c
@@ -198,3 +198,5 @@ static int __init jornada_ssp_init(void)
{
return platform_driver_register(&jornadassp_driver);
}
+
+module_init(jornada_ssp_init);
--
1.7.7.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] mach-sa1100: add missing module_init() call
2012-01-19 18:39 [PATCH] mach-sa1100: add missing module_init() call Linus Walleij
@ 2012-01-21 10:50 ` Kristoffer Ericson
0 siblings, 0 replies; 2+ messages in thread
From: Kristoffer Ericson @ 2012-01-21 10:50 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Jan 19, 2012 at 07:39:22PM +0100, Linus Walleij wrote:
> The Jornada SSP driver is supposed to be initialized by a
> module_init() call, but it was missed at some merge point. Since
> the driver mostly pass calls through it magically works anyway,
> but needs to be rectified.
>
> Cc: Kristoffer Ericson <kristoffer.ericson@gmail.com>
> Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
Thanks for spotting this :)
Acked-by: Kristoffer Ericson <kristoffer.ericson@gmail.com>
> ---
> arch/arm/mach-sa1100/jornada720_ssp.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-sa1100/jornada720_ssp.c b/arch/arm/mach-sa1100/jornada720_ssp.c
> index f50b00b..b412fc0 100644
> --- a/arch/arm/mach-sa1100/jornada720_ssp.c
> +++ b/arch/arm/mach-sa1100/jornada720_ssp.c
> @@ -198,3 +198,5 @@ static int __init jornada_ssp_init(void)
> {
> return platform_driver_register(&jornadassp_driver);
> }
> +
> +module_init(jornada_ssp_init);
> --
> 1.7.7.5
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-01-21 10:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-19 18:39 [PATCH] mach-sa1100: add missing module_init() call Linus Walleij
2012-01-21 10:50 ` Kristoffer Ericson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).