linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3] ARM: mx3: Remove unneeded ifdef's from mm-imx3.c
Date: Sat, 21 Jan 2012 21:43:14 +0100	[thread overview]
Message-ID: <20120121204314.GA14835@pengutronix.de> (raw)
In-Reply-To: <CAOMZO5CaqMm4eNMCWP9Dyb1kC84qx+zg00FyJMw0gs93Qv94Gg@mail.gmail.com>

Hi Fabio,

On Sat, Jan 21, 2012 at 05:16:57PM -0200, Fabio Estevam wrote:
> 2012/1/20 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> 
> > and the problem was not that we can or cannot do kernels for both mx31
> > and mx35, but that we also want to do kernels for only one of them. Did
> > you try to build an mx31-only kernel after your change?
> 
> Ok, just tried it and it fails with:
> 
>   LD      .tmp_vmlinux1
> arch/arm/mach-imx/built-in.o: In function `imx35_init_early':
> mach-mx31_3ds.c:(.init.text+0x50): undefined reference to `mxc_iomux_v3_init'
> arch/arm/mach-imx/built-in.o: In function `imx35_soc_init':
> mach-mx31_3ds.c:(.init.text+0x12c): undefined reference to `mx35_revision'
> 
> I think I can solve this build issue by merging cpu-imx31.c and
> cpu-imx35.c into a single file:
> cpu-imx3.c, using the same idea as in cpu-imx5.c
... or by keeping the #ifdefs :-)

> Would you like me to do this?
I don't care much and pass the question to Sascha.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2012-01-21 20:43 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20 18:43 [PATCH 1/3] ARM: mx3: Remove unneeded ifdef's from mm-imx3.c Fabio Estevam
2012-01-20 18:43 ` [PATCH 2/3] ARM: mx3: Let mx31 and mx35 share the same CCM header file Fabio Estevam
2012-01-20 18:43 ` [PATCH 3/3] ARM: mx3: Let mx31 and mx35 enter in LPM mode in WFI Fabio Estevam
2012-01-26 12:02   ` Sascha Hauer
2012-01-26 12:38     ` Fabio Estevam
2012-01-29 22:30   ` Olof Johansson
2012-01-20 23:29 ` [PATCH 1/3] ARM: mx3: Remove unneeded ifdef's from mm-imx3.c Uwe Kleine-König
2012-01-21 19:16   ` Fabio Estevam
2012-01-21 20:43     ` Uwe Kleine-König [this message]
2012-01-21 20:47       ` Fabio Estevam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120121204314.GA14835@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).