* [PATCH 0/3] s3c-hsudc powerdomain using generic power domains
@ 2012-01-08 20:56 Heiko Stübner
2012-01-08 20:57 ` [PATCH 1/3] s3c-hsudc: Use helper functions instead of generic container_of Heiko Stübner
` (2 more replies)
0 siblings, 3 replies; 19+ messages in thread
From: Heiko Stübner @ 2012-01-08 20:56 UTC (permalink / raw)
To: linux-arm-kernel
The S3C2443/S3C2416/S3C2450 contain a power domain for the usb phy.
Up until now the s3c-hsudc was writing directly to the PWRCFG register
in the (un)init_phy functions to control it.
This patchset introduces a power domain for the usbphy and hooks the
hsudc-device to it. The new runtime_pm calls then handle the enabling
and disabling of the power domain on udc start and stop.
As a result another arch dependency is gone from the driver.
This set applies cleanly to linux-next from 2012-01-06 and is
tested on S3C2416 hardware.
Heiko Stuebner (3):
s3c-hsudc: Use helper functions instead of generic container_of
s3c-hsudc: add basic runtime_pm calls
S3C2443: add power domain for usb phy
arch/arm/mach-s3c2416/Kconfig | 1 +
arch/arm/mach-s3c2443/Kconfig | 1 +
arch/arm/plat-s3c24xx/Kconfig | 7 +++
arch/arm/plat-s3c24xx/Makefile | 1 +
arch/arm/plat-s3c24xx/s3c2443-pm-common.c | 65 +++++++++++++++++++++++++++++
drivers/usb/gadget/s3c-hsudc.c | 25 ++++++-----
6 files changed, 89 insertions(+), 11 deletions(-)
create mode 100644 arch/arm/plat-s3c24xx/s3c2443-pm-common.c
--
1.7.2.3
^ permalink raw reply [flat|nested] 19+ messages in thread* [PATCH 1/3] s3c-hsudc: Use helper functions instead of generic container_of 2012-01-08 20:56 [PATCH 0/3] s3c-hsudc powerdomain using generic power domains Heiko Stübner @ 2012-01-08 20:57 ` Heiko Stübner 2012-01-24 9:36 ` Felipe Balbi 2012-01-08 20:58 ` [PATCH 2/3] s3c-hsudc: add basic runtime_pm calls Heiko Stübner 2012-01-08 20:59 ` [PATCH 3/3] S3C2443: add power domain for usb phy Heiko Stübner 2 siblings, 1 reply; 19+ messages in thread From: Heiko Stübner @ 2012-01-08 20:57 UTC (permalink / raw) To: linux-arm-kernel The helper functions were definied but never used until now. Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- drivers/usb/gadget/s3c-hsudc.c | 10 +++++----- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c index df8661d..41b3a58 100644 --- a/drivers/usb/gadget/s3c-hsudc.c +++ b/drivers/usb/gadget/s3c-hsudc.c @@ -759,7 +759,7 @@ static int s3c_hsudc_ep_enable(struct usb_ep *_ep, unsigned long flags; u32 ecr = 0; - hsep = container_of(_ep, struct s3c_hsudc_ep, ep); + hsep = our_ep(_ep); if (!_ep || !desc || hsep->desc || _ep->name == ep0name || desc->bDescriptorType != USB_DT_ENDPOINT || hsep->bEndpointAddress != desc->bEndpointAddress @@ -853,7 +853,7 @@ static void s3c_hsudc_free_request(struct usb_ep *ep, struct usb_request *_req) { struct s3c_hsudc_req *hsreq; - hsreq = container_of(_req, struct s3c_hsudc_req, req); + hsreq = our_req(_req); WARN_ON(!list_empty(&hsreq->queue)); kfree(hsreq); } @@ -876,12 +876,12 @@ static int s3c_hsudc_queue(struct usb_ep *_ep, struct usb_request *_req, u32 offset; u32 csr; - hsreq = container_of(_req, struct s3c_hsudc_req, req); + hsreq = our_req(_req); if ((!_req || !_req->complete || !_req->buf || !list_empty(&hsreq->queue))) return -EINVAL; - hsep = container_of(_ep, struct s3c_hsudc_ep, ep); + hsep = our_ep(_ep); hsudc = hsep->dev; if (!hsudc->driver || hsudc->gadget.speed == USB_SPEED_UNKNOWN) return -ESHUTDOWN; @@ -935,7 +935,7 @@ static int s3c_hsudc_dequeue(struct usb_ep *_ep, struct usb_request *_req) struct s3c_hsudc_req *hsreq; unsigned long flags; - hsep = container_of(_ep, struct s3c_hsudc_ep, ep); + hsep = our_ep(_ep); if (!_ep || hsep->ep.name == ep0name) return -EINVAL; -- 1.7.2.3 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 1/3] s3c-hsudc: Use helper functions instead of generic container_of 2012-01-08 20:57 ` [PATCH 1/3] s3c-hsudc: Use helper functions instead of generic container_of Heiko Stübner @ 2012-01-24 9:36 ` Felipe Balbi 0 siblings, 0 replies; 19+ messages in thread From: Felipe Balbi @ 2012-01-24 9:36 UTC (permalink / raw) To: linux-arm-kernel On Sun, Jan 08, 2012 at 09:57:55PM +0100, Heiko St?bner wrote: > The helper functions were definied but never used until now. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> applied, thanks -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120124/b9abfc67/attachment.sig> ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 2/3] s3c-hsudc: add basic runtime_pm calls 2012-01-08 20:56 [PATCH 0/3] s3c-hsudc powerdomain using generic power domains Heiko Stübner 2012-01-08 20:57 ` [PATCH 1/3] s3c-hsudc: Use helper functions instead of generic container_of Heiko Stübner @ 2012-01-08 20:58 ` Heiko Stübner 2012-01-24 9:37 ` Felipe Balbi 2012-01-08 20:59 ` [PATCH 3/3] S3C2443: add power domain for usb phy Heiko Stübner 2 siblings, 1 reply; 19+ messages in thread From: Heiko Stübner @ 2012-01-08 20:58 UTC (permalink / raw) To: linux-arm-kernel This will enable the system to check for activity of the usb gadget and also in a later patch to control the usbphy power-domain. When handling the power domain there, it will be possible to remove another reference to architecture code. Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- drivers/usb/gadget/s3c-hsudc.c | 9 +++++++++ 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c index 41b3a58..5e87293 100644 --- a/drivers/usb/gadget/s3c-hsudc.c +++ b/drivers/usb/gadget/s3c-hsudc.c @@ -30,6 +30,7 @@ #include <linux/prefetch.h> #include <linux/platform_data/s3c-hsudc.h> #include <linux/regulator/consumer.h> +#include <linux/pm_runtime.h> #include <mach/regs-s3c2443-clock.h> @@ -1178,6 +1179,9 @@ static int s3c_hsudc_start(struct usb_gadget *gadget, dev_info(hsudc->dev, "bound driver %s\n", driver->driver.name); s3c_hsudc_reconfig(hsudc); + + pm_runtime_get_sync(hsudc->dev); + s3c_hsudc_init_phy(); if (hsudc->pd->gpio_init) hsudc->pd->gpio_init(); @@ -1208,6 +1212,9 @@ static int s3c_hsudc_stop(struct usb_gadget *gadget, hsudc->gadget.dev.driver = NULL; hsudc->gadget.speed = USB_SPEED_UNKNOWN; s3c_hsudc_uninit_phy(); + + pm_runtime_put(hsudc->dev); + if (hsudc->pd->gpio_uninit) hsudc->pd->gpio_uninit(); s3c_hsudc_stop_activity(hsudc); @@ -1362,6 +1369,8 @@ static int __devinit s3c_hsudc_probe(struct platform_device *pdev) if (ret) goto err_add_udc; + pm_runtime_enable(dev); + return 0; err_add_udc: device_unregister(&hsudc->gadget.dev); -- 1.7.2.3 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 2/3] s3c-hsudc: add basic runtime_pm calls 2012-01-08 20:58 ` [PATCH 2/3] s3c-hsudc: add basic runtime_pm calls Heiko Stübner @ 2012-01-24 9:37 ` Felipe Balbi 0 siblings, 0 replies; 19+ messages in thread From: Felipe Balbi @ 2012-01-24 9:37 UTC (permalink / raw) To: linux-arm-kernel On Sun, Jan 08, 2012 at 09:58:28PM +0100, Heiko St?bner wrote: > This will enable the system to check for activity of the usb gadget > and also in a later patch to control the usbphy power-domain. > When handling the power domain there, it will be possible to remove > another reference to architecture code. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> applied, thanks -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120124/675c6db5/attachment.sig> ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-08 20:56 [PATCH 0/3] s3c-hsudc powerdomain using generic power domains Heiko Stübner 2012-01-08 20:57 ` [PATCH 1/3] s3c-hsudc: Use helper functions instead of generic container_of Heiko Stübner 2012-01-08 20:58 ` [PATCH 2/3] s3c-hsudc: add basic runtime_pm calls Heiko Stübner @ 2012-01-08 20:59 ` Heiko Stübner 2012-01-24 9:38 ` Felipe Balbi 2 siblings, 1 reply; 19+ messages in thread From: Heiko Stübner @ 2012-01-08 20:59 UTC (permalink / raw) To: linux-arm-kernel The phy-power-handling is common to S3C2443/2416/2450, so introduce a s3c2443-pm-common.c to handle this for all of them. This makes it possible to remove the raw write to the PWRCFG-register from the s3c-hsudc driver. Signed-off-by: Heiko Stuebner <heiko@sntech.de> --- arch/arm/mach-s3c2416/Kconfig | 1 + arch/arm/mach-s3c2443/Kconfig | 1 + arch/arm/plat-s3c24xx/Kconfig | 7 +++ arch/arm/plat-s3c24xx/Makefile | 1 + arch/arm/plat-s3c24xx/s3c2443-pm-common.c | 65 +++++++++++++++++++++++++++++ drivers/usb/gadget/s3c-hsudc.c | 6 --- 6 files changed, 75 insertions(+), 6 deletions(-) create mode 100644 arch/arm/plat-s3c24xx/s3c2443-pm-common.c diff --git a/arch/arm/mach-s3c2416/Kconfig b/arch/arm/mach-s3c2416/Kconfig index 84c7b03..240aef7 100644 --- a/arch/arm/mach-s3c2416/Kconfig +++ b/arch/arm/mach-s3c2416/Kconfig @@ -15,6 +15,7 @@ config CPU_S3C2416 select CPU_LLSERIAL_S3C2440 select SAMSUNG_CLKSRC select S3C2443_CLOCK + select S3C2443_PM_COMMON help Support for the S3C2416 SoC from the S3C24XX line diff --git a/arch/arm/mach-s3c2443/Kconfig b/arch/arm/mach-s3c2443/Kconfig index 8814031..3bff23f 100644 --- a/arch/arm/mach-s3c2443/Kconfig +++ b/arch/arm/mach-s3c2443/Kconfig @@ -10,6 +10,7 @@ config CPU_S3C2443 select CPU_LLSERIAL_S3C2440 select SAMSUNG_CLKSRC select S3C2443_CLOCK + select S3C2443_PM_COMMON help Support for the S3C2443 SoC from the S3C24XX line diff --git a/arch/arm/plat-s3c24xx/Kconfig b/arch/arm/plat-s3c24xx/Kconfig index d8973ac..0a9f37c 100644 --- a/arch/arm/plat-s3c24xx/Kconfig +++ b/arch/arm/plat-s3c24xx/Kconfig @@ -50,6 +50,13 @@ config S3C2443_CLOCK Clock code for the S3C2443 and similar processors, which includes the S3C2416 and S3C2450. +config S3C2443_PM_COMMON + bool + select PM_GENERIC_DOMAINS + help + Common power management code for the S3C2443 and similar processors, + which include the S3C2416 and S3C2450. + config S3C24XX_DCLK bool help diff --git a/arch/arm/plat-s3c24xx/Makefile b/arch/arm/plat-s3c24xx/Makefile index b2b0112..300f77c 100644 --- a/arch/arm/plat-s3c24xx/Makefile +++ b/arch/arm/plat-s3c24xx/Makefile @@ -29,6 +29,7 @@ obj-$(CONFIG_PM) += irq-pm.o obj-$(CONFIG_PM) += sleep.o obj-$(CONFIG_S3C2410_CLOCK) += s3c2410-clock.o obj-$(CONFIG_S3C2443_CLOCK) += s3c2443-clock.o +obj-$(CONFIG_S3C2443_PM_COMMON) += s3c2443-pm-common.o obj-$(CONFIG_S3C2410_DMA) += dma.o obj-$(CONFIG_S3C2410_IOTIMING) += s3c2410-iotiming.o obj-$(CONFIG_S3C2412_IOTIMING) += s3c2412-iotiming.o diff --git a/arch/arm/plat-s3c24xx/s3c2443-pm-common.c b/arch/arm/plat-s3c24xx/s3c2443-pm-common.c new file mode 100644 index 0000000..b9aaf9a --- /dev/null +++ b/arch/arm/plat-s3c24xx/s3c2443-pm-common.c @@ -0,0 +1,65 @@ +/* + * S3C2443,S3C2416,S3C2450 Power management support + * + * Copyright (c) 2011 Heiko Stuebner <heiko@sntech.de> + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2 of the License, or + * (at your option) any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. +*/ + +#include <linux/io.h> +#include <linux/pm_domain.h> + +#include <mach/regs-s3c2443-clock.h> +#include <plat/devs.h> + + +static int s3c2443_usbphy_off(struct generic_pm_domain *domain) +{ + u32 val; + + val = __raw_readl(S3C2443_PWRCFG); + val &= ~(S3C2443_PWRCFG_USBPHY); + __raw_writel(val, S3C2443_PWRCFG); + + return 0; +} + +static int s3c2443_usbphy_on(struct generic_pm_domain *domain) +{ + u32 val; + + val = __raw_readl(S3C2443_PWRCFG); + val |= S3C2443_PWRCFG_USBPHY; + __raw_writel(val, S3C2443_PWRCFG); + + return 0; +} + +static struct generic_pm_domain s3c2443_usbphy_pd = { + .power_off = s3c2443_usbphy_off, + .power_on = s3c2443_usbphy_on, +}; + +static int __init s3c2443_pm_common_init(void) +{ + pm_genpd_init(&s3c2443_usbphy_pd, NULL, false); + pm_genpd_add_device(&s3c2443_usbphy_pd, &s3c_device_usb_hsudc.dev); + + return 0; +} +arch_initcall(s3c2443_pm_common_init); + +static __init int s3c2443_pm_common_late_initcall(void) +{ + pm_genpd_poweroff_unused(); + return 0; +} +late_initcall(s3c2443_pm_common_late_initcall); diff --git a/drivers/usb/gadget/s3c-hsudc.c b/drivers/usb/gadget/s3c-hsudc.c index 5e87293..9a81ad3 100644 --- a/drivers/usb/gadget/s3c-hsudc.c +++ b/drivers/usb/gadget/s3c-hsudc.c @@ -195,9 +195,6 @@ static void s3c_hsudc_init_phy(void) { u32 cfg; - cfg = readl(S3C2443_PWRCFG) | S3C2443_PWRCFG_USBPHY; - writel(cfg, S3C2443_PWRCFG); - cfg = readl(S3C2443_URSTCON); cfg |= (S3C2443_URSTCON_FUNCRST | S3C2443_URSTCON_PHYRST); writel(cfg, S3C2443_URSTCON); @@ -229,9 +226,6 @@ static void s3c_hsudc_uninit_phy(void) { u32 cfg; - cfg = readl(S3C2443_PWRCFG) & ~S3C2443_PWRCFG_USBPHY; - writel(cfg, S3C2443_PWRCFG); - writel(S3C2443_PHYPWR_FSUSPEND, S3C2443_PHYPWR); cfg = readl(S3C2443_UCLKCON) & ~S3C2443_UCLKCON_FUNC_CLKEN; -- 1.7.2.3 ^ permalink raw reply related [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-08 20:59 ` [PATCH 3/3] S3C2443: add power domain for usb phy Heiko Stübner @ 2012-01-24 9:38 ` Felipe Balbi 2012-01-24 9:50 ` Heiko Stübner 0 siblings, 1 reply; 19+ messages in thread From: Felipe Balbi @ 2012-01-24 9:38 UTC (permalink / raw) To: linux-arm-kernel Hi, On Sun, Jan 08, 2012 at 09:59:02PM +0100, Heiko St?bner wrote: > The phy-power-handling is common to S3C2443/2416/2450, so introduce a > s3c2443-pm-common.c to handle this for all of them. > > This makes it possible to remove the raw write to the PWRCFG-register > from the s3c-hsudc driver. > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> I believe this doesn't really depend on previous patches (??) In that case, it can be carried with s3c's tree: Acked-by: Felipe Balbi <balbi@ti.com> -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120124/17509f4c/attachment.sig> ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-24 9:38 ` Felipe Balbi @ 2012-01-24 9:50 ` Heiko Stübner 2012-01-24 9:51 ` Felipe Balbi 0 siblings, 1 reply; 19+ messages in thread From: Heiko Stübner @ 2012-01-24 9:50 UTC (permalink / raw) To: linux-arm-kernel Hi Felipe, Am Dienstag, 24. Januar 2012, 10:38:32 schrieb Felipe Balbi: > Hi, > > On Sun, Jan 08, 2012 at 09:59:02PM +0100, Heiko St?bner wrote: > > The phy-power-handling is common to S3C2443/2416/2450, so introduce a > > s3c2443-pm-common.c to handle this for all of them. > > > > This makes it possible to remove the raw write to the PWRCFG-register > > from the s3c-hsudc driver. > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > I believe this doesn't really depend on previous patches (??) In that > case, it can be carried with s3c's tree: it does depend on the previous patch [2/3], as the device power domain is controlled through the runtime-pm subsystem whose calls were added in it. Heiko ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-24 9:50 ` Heiko Stübner @ 2012-01-24 9:51 ` Felipe Balbi 2012-01-24 10:09 ` Heiko Stübner 2012-01-24 10:13 ` Heiko Stübner 0 siblings, 2 replies; 19+ messages in thread From: Felipe Balbi @ 2012-01-24 9:51 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jan 24, 2012 at 10:50:14AM +0100, Heiko St?bner wrote: > Hi Felipe, > > Am Dienstag, 24. Januar 2012, 10:38:32 schrieb Felipe Balbi: > > Hi, > > > > On Sun, Jan 08, 2012 at 09:59:02PM +0100, Heiko St?bner wrote: > > > The phy-power-handling is common to S3C2443/2416/2450, so introduce a > > > s3c2443-pm-common.c to handle this for all of them. > > > > > > This makes it possible to remove the raw write to the PWRCFG-register > > > from the s3c-hsudc driver. > > > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > > > I believe this doesn't really depend on previous patches (??) In that > > case, it can be carried with s3c's tree: > it does depend on the previous patch [2/3], as the device power domain is > controlled through the runtime-pm subsystem whose calls were added in it. then I will need proper acks to carry this patch. -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120124/18c832e2/attachment-0001.sig> ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-24 9:51 ` Felipe Balbi @ 2012-01-24 10:09 ` Heiko Stübner 2012-01-24 10:12 ` Felipe Balbi 2012-01-24 10:13 ` Heiko Stübner 1 sibling, 1 reply; 19+ messages in thread From: Heiko Stübner @ 2012-01-24 10:09 UTC (permalink / raw) To: linux-arm-kernel Am Dienstag, 24. Januar 2012, 10:51:31 schrieb Felipe Balbi: > On Tue, Jan 24, 2012 at 10:50:14AM +0100, Heiko St?bner wrote: > > Hi Felipe, > > > > Am Dienstag, 24. Januar 2012, 10:38:32 schrieb Felipe Balbi: > > > Hi, > > > > > > On Sun, Jan 08, 2012 at 09:59:02PM +0100, Heiko St?bner wrote: > > > > The phy-power-handling is common to S3C2443/2416/2450, so introduce a > > > > s3c2443-pm-common.c to handle this for all of them. > > > > > > > > This makes it possible to remove the raw write to the PWRCFG-register > > > > from the s3c-hsudc driver. > > > > > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > > > > > I believe this doesn't really depend on previous patches (??) In that > > > > > case, it can be carried with s3c's tree: > > it does depend on the previous patch [2/3], as the device power domain is > > controlled through the runtime-pm subsystem whose calls were added in it. > > then I will need proper acks to carry this patch. ok, I will pester Kukjin Kim more about it to get the needed ack :-) . If changes are requested to this third patch should I only resubmit this one or all of them again - i.e. will you still keep the first two patches? Heiko ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-24 10:09 ` Heiko Stübner @ 2012-01-24 10:12 ` Felipe Balbi 0 siblings, 0 replies; 19+ messages in thread From: Felipe Balbi @ 2012-01-24 10:12 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jan 24, 2012 at 11:09:48AM +0100, Heiko St?bner wrote: > Am Dienstag, 24. Januar 2012, 10:51:31 schrieb Felipe Balbi: > > On Tue, Jan 24, 2012 at 10:50:14AM +0100, Heiko St?bner wrote: > > > Hi Felipe, > > > > > > Am Dienstag, 24. Januar 2012, 10:38:32 schrieb Felipe Balbi: > > > > Hi, > > > > > > > > On Sun, Jan 08, 2012 at 09:59:02PM +0100, Heiko St?bner wrote: > > > > > The phy-power-handling is common to S3C2443/2416/2450, so introduce a > > > > > s3c2443-pm-common.c to handle this for all of them. > > > > > > > > > > This makes it possible to remove the raw write to the PWRCFG-register > > > > > from the s3c-hsudc driver. > > > > > > > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > > > > > > > I believe this doesn't really depend on previous patches (??) In that > > > > > > > case, it can be carried with s3c's tree: > > > it does depend on the previous patch [2/3], as the device power domain is > > > controlled through the runtime-pm subsystem whose calls were added in it. > > > > then I will need proper acks to carry this patch. > > ok, I will pester Kukjin Kim more about it to get the needed ack :-) . > > If changes are requested to this third patch should I only resubmit this one > or all of them again - i.e. will you still keep the first two patches? first two are already applied so no need to resend them :-) -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120124/ca419423/attachment.sig> ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-24 9:51 ` Felipe Balbi 2012-01-24 10:09 ` Heiko Stübner @ 2012-01-24 10:13 ` Heiko Stübner 2012-01-24 10:15 ` Felipe Balbi 1 sibling, 1 reply; 19+ messages in thread From: Heiko Stübner @ 2012-01-24 10:13 UTC (permalink / raw) To: linux-arm-kernel sorry for mail spam :-) Am Dienstag, 24. Januar 2012, 10:51:31 schrieb Felipe Balbi: > On Tue, Jan 24, 2012 at 10:50:14AM +0100, Heiko St?bner wrote: > > Hi Felipe, > > > > Am Dienstag, 24. Januar 2012, 10:38:32 schrieb Felipe Balbi: > > > Hi, > > > > > > On Sun, Jan 08, 2012 at 09:59:02PM +0100, Heiko St?bner wrote: > > > > The phy-power-handling is common to S3C2443/2416/2450, so introduce a > > > > s3c2443-pm-common.c to handle this for all of them. > > > > > > > > This makes it possible to remove the raw write to the PWRCFG-register > > > > from the s3c-hsudc driver. > > > > > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > > > > > I believe this doesn't really depend on previous patches (??) In that > > > > > case, it can be carried with s3c's tree: > > it does depend on the previous patch [2/3], as the device power domain is > > controlled through the runtime-pm subsystem whose calls were added in it. > > then I will need proper acks to carry this patch. another possibility would be to have patch 2 and 3 get in through the samsung tree, as the majority of the change lies on this side (i.e. introducing a new file in plat-s3c24xx) Heiko ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-24 10:13 ` Heiko Stübner @ 2012-01-24 10:15 ` Felipe Balbi 2012-01-24 10:31 ` Heiko Stübner 0 siblings, 1 reply; 19+ messages in thread From: Felipe Balbi @ 2012-01-24 10:15 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jan 24, 2012 at 11:13:00AM +0100, Heiko St?bner wrote: > sorry for mail spam :-) > > Am Dienstag, 24. Januar 2012, 10:51:31 schrieb Felipe Balbi: > > On Tue, Jan 24, 2012 at 10:50:14AM +0100, Heiko St?bner wrote: > > > Hi Felipe, > > > > > > Am Dienstag, 24. Januar 2012, 10:38:32 schrieb Felipe Balbi: > > > > Hi, > > > > > > > > On Sun, Jan 08, 2012 at 09:59:02PM +0100, Heiko St?bner wrote: > > > > > The phy-power-handling is common to S3C2443/2416/2450, so introduce a > > > > > s3c2443-pm-common.c to handle this for all of them. > > > > > > > > > > This makes it possible to remove the raw write to the PWRCFG-register > > > > > from the s3c-hsudc driver. > > > > > > > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > > > > > > > I believe this doesn't really depend on previous patches (??) In that > > > > > > > case, it can be carried with s3c's tree: > > > it does depend on the previous patch [2/3], as the device power domain is > > > controlled through the runtime-pm subsystem whose calls were added in it. > > > > then I will need proper acks to carry this patch. > another possibility would be to have patch 2 and 3 get in through the samsung > tree, as the majority of the change lies on this side (i.e. introducing a new > file in plat-s3c24xx) yet another one, would be to defer patch 3/3 by one merge window ;-) -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120124/fe17dcad/attachment-0001.sig> ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-24 10:15 ` Felipe Balbi @ 2012-01-24 10:31 ` Heiko Stübner 2012-01-24 13:01 ` Kukjin Kim 0 siblings, 1 reply; 19+ messages in thread From: Heiko Stübner @ 2012-01-24 10:31 UTC (permalink / raw) To: linux-arm-kernel Am Dienstag, 24. Januar 2012, 11:15:11 schrieb Felipe Balbi: > On Tue, Jan 24, 2012 at 11:13:00AM +0100, Heiko St?bner wrote: > > sorry for mail spam :-) > > > > Am Dienstag, 24. Januar 2012, 10:51:31 schrieb Felipe Balbi: > > > On Tue, Jan 24, 2012 at 10:50:14AM +0100, Heiko St?bner wrote: > > > > Hi Felipe, > > > > > > > > Am Dienstag, 24. Januar 2012, 10:38:32 schrieb Felipe Balbi: > > > > > Hi, > > > > > > > > > > On Sun, Jan 08, 2012 at 09:59:02PM +0100, Heiko St?bner wrote: > > > > > > The phy-power-handling is common to S3C2443/2416/2450, so > > > > > > introduce a s3c2443-pm-common.c to handle this for all of them. > > > > > > > > > > > > This makes it possible to remove the raw write to the > > > > > > PWRCFG-register from the s3c-hsudc driver. > > > > > > > > > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > > > > > > > > > I believe this doesn't really depend on previous patches (??) In > > > > > that > > > > > > > > > case, it can be carried with s3c's tree: > > > > it does depend on the previous patch [2/3], as the device power > > > > domain is controlled through the runtime-pm subsystem whose calls > > > > were added in it. > > > > > > then I will need proper acks to carry this patch. > > > > another possibility would be to have patch 2 and 3 get in through the > > samsung tree, as the majority of the change lies on this side (i.e. > > introducing a new file in plat-s3c24xx) > > yet another one, would be to defer patch 3/3 by one merge window ;-) also fine by me ;-) But let's see first what Kgene says. ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-24 10:31 ` Heiko Stübner @ 2012-01-24 13:01 ` Kukjin Kim 2012-01-24 13:07 ` Felipe Balbi 2012-02-01 16:35 ` Heiko Stübner 0 siblings, 2 replies; 19+ messages in thread From: Kukjin Kim @ 2012-01-24 13:01 UTC (permalink / raw) To: linux-arm-kernel Heiko St?bner wrote: > > Am Dienstag, 24. Januar 2012, 11:15:11 schrieb Felipe Balbi: > > On Tue, Jan 24, 2012 at 11:13:00AM +0100, Heiko St?bner wrote: > > > sorry for mail spam :-) > > > > > > Am Dienstag, 24. Januar 2012, 10:51:31 schrieb Felipe Balbi: > > > > On Tue, Jan 24, 2012 at 10:50:14AM +0100, Heiko St?bner wrote: > > > > > Hi Felipe, > > > > > > > > > > Am Dienstag, 24. Januar 2012, 10:38:32 schrieb Felipe Balbi: > > > > > > Hi, > > > > > > > > > > > > On Sun, Jan 08, 2012 at 09:59:02PM +0100, Heiko St?bner wrote: > > > > > > > The phy-power-handling is common to S3C2443/2416/2450, so > > > > > > > introduce a s3c2443-pm-common.c to handle this for all of them. > > > > > > > > > > > > > > This makes it possible to remove the raw write to the > > > > > > > PWRCFG-register from the s3c-hsudc driver. > > > > > > > > > > > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > > > > > > > > > > > I believe this doesn't really depend on previous patches (??) In > > > > > > that > > > > > > > > > > > case, it can be carried with s3c's tree: > > > > > it does depend on the previous patch [2/3], as the device power > > > > > domain is controlled through the runtime-pm subsystem whose calls > > > > > were added in it. > > > > > > > > then I will need proper acks to carry this patch. > > > > > > another possibility would be to have patch 2 and 3 get in through the > > > samsung tree, as the majority of the change lies on this side (i.e. > > > introducing a new file in plat-s3c24xx) > > > > yet another one, would be to defer patch 3/3 by one merge window ;-) > > also fine by me ;-) > > But let's see first what Kgene says. Hi all, Sorry for join lately on this. I think we need to implement more pm domain for s3c24xx as well usbphy. So if Felipe is ok, I'd like to handle Heiko's 2nd and 3rd patches in my tree. Of course, I need Felipe's ack before that. BTW, frankly, I'm not sure we can finish supporting pm domain for all of s3c24xx for v3.4 :) And, Heiko, I don't know why its name is -pm-common.c, how about just -pm.c like others? Yes, when all of s3c24xx can be supported on that, just s3c24xx-pm.c would be better. But right now, s3c2443-pm.c is ok or we need to think about that again. Because as I said, I'm doing merge s3c24xx directories and it's almost done. And the form of subject would be 'ARM: S3C24XX: ...', actually there were discussions about that. Thanks. Best regards, Kgene. -- Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer, SW Solution Development Team, Samsung Electronics Co., Ltd. ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-24 13:01 ` Kukjin Kim @ 2012-01-24 13:07 ` Felipe Balbi 2012-01-24 13:27 ` Heiko Stübner 2012-02-01 16:35 ` Heiko Stübner 1 sibling, 1 reply; 19+ messages in thread From: Felipe Balbi @ 2012-01-24 13:07 UTC (permalink / raw) To: linux-arm-kernel Hi, On Tue, Jan 24, 2012 at 10:01:33PM +0900, Kukjin Kim wrote: > Heiko St?bner wrote: > > > > Am Dienstag, 24. Januar 2012, 11:15:11 schrieb Felipe Balbi: > > > On Tue, Jan 24, 2012 at 11:13:00AM +0100, Heiko St?bner wrote: > > > > sorry for mail spam :-) > > > > > > > > Am Dienstag, 24. Januar 2012, 10:51:31 schrieb Felipe Balbi: > > > > > On Tue, Jan 24, 2012 at 10:50:14AM +0100, Heiko St?bner wrote: > > > > > > Hi Felipe, > > > > > > > > > > > > Am Dienstag, 24. Januar 2012, 10:38:32 schrieb Felipe Balbi: > > > > > > > Hi, > > > > > > > > > > > > > > On Sun, Jan 08, 2012 at 09:59:02PM +0100, Heiko St?bner wrote: > > > > > > > > The phy-power-handling is common to S3C2443/2416/2450, so > > > > > > > > introduce a s3c2443-pm-common.c to handle this for all of them. > > > > > > > > > > > > > > > > This makes it possible to remove the raw write to the > > > > > > > > PWRCFG-register from the s3c-hsudc driver. > > > > > > > > > > > > > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > > > > > > > > > > > > > I believe this doesn't really depend on previous patches (??) In > > > > > > > that > > > > > > > > > > > > > case, it can be carried with s3c's tree: > > > > > > it does depend on the previous patch [2/3], as the device power > > > > > > domain is controlled through the runtime-pm subsystem whose calls > > > > > > were added in it. > > > > > > > > > > then I will need proper acks to carry this patch. > > > > > > > > another possibility would be to have patch 2 and 3 get in through the > > > > samsung tree, as the majority of the change lies on this side (i.e. > > > > introducing a new file in plat-s3c24xx) > > > > > > yet another one, would be to defer patch 3/3 by one merge window ;-) > > > > also fine by me ;-) > > > > But let's see first what Kgene says. > > Hi all, > > Sorry for join lately on this. > > I think we need to implement more pm domain for s3c24xx as well > usbphy. So if Felipe is ok, I'd like to handle Heiko's 2nd and 3rd > patches in my tree. Of course, I need Felipe's ack before that. > BTW, frankly, I'm not sure we can finish supporting pm domain for all > of s3c24xx for v3.4 :) In that case, how about we take things slow ? I can carry pm-runtime patch (2/3) and by 3.5 or 3.6 you will only need to touch arch/arm/-related code. If you guarantee that it won't make it in 3.4, I'm ok carrying pm-runtime patch as it won't break anything anyway (I suppose). -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120124/d9c08cdb/attachment.sig> ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-24 13:07 ` Felipe Balbi @ 2012-01-24 13:27 ` Heiko Stübner 2012-01-24 13:30 ` Felipe Balbi 0 siblings, 1 reply; 19+ messages in thread From: Heiko Stübner @ 2012-01-24 13:27 UTC (permalink / raw) To: linux-arm-kernel Am Dienstag, 24. Januar 2012, 14:07:56 schrieb Felipe Balbi: > Hi, > > On Tue, Jan 24, 2012 at 10:01:33PM +0900, Kukjin Kim wrote: > > Heiko St?bner wrote: > > > Am Dienstag, 24. Januar 2012, 11:15:11 schrieb Felipe Balbi: > > > > On Tue, Jan 24, 2012 at 11:13:00AM +0100, Heiko St?bner wrote: > > > > > sorry for mail spam :-) > > > > > > > > > > Am Dienstag, 24. Januar 2012, 10:51:31 schrieb Felipe Balbi: > > > > > > On Tue, Jan 24, 2012 at 10:50:14AM +0100, Heiko St?bner wrote: > > > > > > > Hi Felipe, > > > > > > > > > > > > > > Am Dienstag, 24. Januar 2012, 10:38:32 schrieb Felipe Balbi: > > > > > > > > Hi, > > > > > > > > > > > > > > > > On Sun, Jan 08, 2012 at 09:59:02PM +0100, Heiko St?bner wrote: > > > > > > > > > The phy-power-handling is common to S3C2443/2416/2450, so > > > > > > > > > introduce a s3c2443-pm-common.c to handle this for all of > > > > > > > > > them. > > > > > > > > > > > > > > > > > > This makes it possible to remove the raw write to the > > > > > > > > > PWRCFG-register from the s3c-hsudc driver. > > > > > > > > > > > > > > > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > > > > > > > > > > > > > > > I believe this doesn't really depend on previous patches (??) > > > > > > > > In that > > > > > > > > > > > > > > > case, it can be carried with s3c's tree: > > > > > > > it does depend on the previous patch [2/3], as the device power > > > > > > > domain is controlled through the runtime-pm subsystem whose > > > > > > > calls were added in it. > > > > > > > > > > > > then I will need proper acks to carry this patch. > > > > > > > > > > another possibility would be to have patch 2 and 3 get in through > > > > > the samsung tree, as the majority of the change lies on this side > > > > > (i.e. introducing a new file in plat-s3c24xx) > > > > > > > > yet another one, would be to defer patch 3/3 by one merge window ;-) > > > > > > also fine by me ;-) > > > > > > But let's see first what Kgene says. > > > > Hi all, > > > > Sorry for join lately on this. > > > > I think we need to implement more pm domain for s3c24xx as well > > usbphy. So if Felipe is ok, I'd like to handle Heiko's 2nd and 3rd > > patches in my tree. Of course, I need Felipe's ack before that. > > BTW, frankly, I'm not sure we can finish supporting pm domain for all > > of s3c24xx for v3.4 :) > > In that case, how about we take things slow ? I can carry pm-runtime > patch (2/3) and by 3.5 or 3.6 you will only need to touch > arch/arm/-related code. > > If you guarantee that it won't make it in 3.4, I'm ok carrying > pm-runtime patch as it won't break anything anyway (I suppose). Seems reasonable to me. The pm-runtime patch does not break anything - it simply does nothing without either some runtime-pm functions or the power domain work. So I would second that we handle the power domain stuff after Kgene got the mach directories merged for 3.4, i.e. drop the patch (3/3) for now and I will resubmit it when the time comes. Heiko ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-24 13:27 ` Heiko Stübner @ 2012-01-24 13:30 ` Felipe Balbi 0 siblings, 0 replies; 19+ messages in thread From: Felipe Balbi @ 2012-01-24 13:30 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jan 24, 2012 at 02:27:21PM +0100, Heiko St?bner wrote: > Am Dienstag, 24. Januar 2012, 14:07:56 schrieb Felipe Balbi: > > Hi, > > > > On Tue, Jan 24, 2012 at 10:01:33PM +0900, Kukjin Kim wrote: > > > Heiko St?bner wrote: > > > > Am Dienstag, 24. Januar 2012, 11:15:11 schrieb Felipe Balbi: > > > > > On Tue, Jan 24, 2012 at 11:13:00AM +0100, Heiko St?bner wrote: > > > > > > sorry for mail spam :-) > > > > > > > > > > > > Am Dienstag, 24. Januar 2012, 10:51:31 schrieb Felipe Balbi: > > > > > > > On Tue, Jan 24, 2012 at 10:50:14AM +0100, Heiko St?bner wrote: > > > > > > > > Hi Felipe, > > > > > > > > > > > > > > > > Am Dienstag, 24. Januar 2012, 10:38:32 schrieb Felipe Balbi: > > > > > > > > > Hi, > > > > > > > > > > > > > > > > > > On Sun, Jan 08, 2012 at 09:59:02PM +0100, Heiko St?bner wrote: > > > > > > > > > > The phy-power-handling is common to S3C2443/2416/2450, so > > > > > > > > > > introduce a s3c2443-pm-common.c to handle this for all of > > > > > > > > > > them. > > > > > > > > > > > > > > > > > > > > This makes it possible to remove the raw write to the > > > > > > > > > > PWRCFG-register from the s3c-hsudc driver. > > > > > > > > > > > > > > > > > > > > Signed-off-by: Heiko Stuebner <heiko@sntech.de> > > > > > > > > > > > > > > > > > > I believe this doesn't really depend on previous patches (??) > > > > > > > > > In that > > > > > > > > > > > > > > > > > case, it can be carried with s3c's tree: > > > > > > > > it does depend on the previous patch [2/3], as the device power > > > > > > > > domain is controlled through the runtime-pm subsystem whose > > > > > > > > calls were added in it. > > > > > > > > > > > > > > then I will need proper acks to carry this patch. > > > > > > > > > > > > another possibility would be to have patch 2 and 3 get in through > > > > > > the samsung tree, as the majority of the change lies on this side > > > > > > (i.e. introducing a new file in plat-s3c24xx) > > > > > > > > > > yet another one, would be to defer patch 3/3 by one merge window ;-) > > > > > > > > also fine by me ;-) > > > > > > > > But let's see first what Kgene says. > > > > > > Hi all, > > > > > > Sorry for join lately on this. > > > > > > I think we need to implement more pm domain for s3c24xx as well > > > usbphy. So if Felipe is ok, I'd like to handle Heiko's 2nd and 3rd > > > patches in my tree. Of course, I need Felipe's ack before that. > > > BTW, frankly, I'm not sure we can finish supporting pm domain for all > > > of s3c24xx for v3.4 :) > > > > In that case, how about we take things slow ? I can carry pm-runtime > > patch (2/3) and by 3.5 or 3.6 you will only need to touch > > arch/arm/-related code. > > > > If you guarantee that it won't make it in 3.4, I'm ok carrying > > pm-runtime patch as it won't break anything anyway (I suppose). > > Seems reasonable to me. The pm-runtime patch does not break anything - it > simply does nothing without either some runtime-pm functions or the power > domain work. > > So I would second that we handle the power domain stuff after Kgene got the > mach directories merged for 3.4, i.e. drop the patch (3/3) for now and I will > resubmit it when the time comes. sounds great to me :-) Thanks guys -- balbi -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 836 bytes Desc: Digital signature URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120124/904bea41/attachment-0001.sig> ^ permalink raw reply [flat|nested] 19+ messages in thread
* [PATCH 3/3] S3C2443: add power domain for usb phy 2012-01-24 13:01 ` Kukjin Kim 2012-01-24 13:07 ` Felipe Balbi @ 2012-02-01 16:35 ` Heiko Stübner 1 sibling, 0 replies; 19+ messages in thread From: Heiko Stübner @ 2012-02-01 16:35 UTC (permalink / raw) To: linux-arm-kernel Hi Kgene, Am Dienstag 24 Januar 2012, 14:01:33 schrieb Kukjin Kim: > Because as I said, I'm doing merge s3c24xx directories and it's almost done. any news of this or can I help in some way? I'm asking because I would like to put stuff on top of your merge (for example support for spi-s3c64xx for the S3C2416) for 3.4 . Thanks Heiko ^ permalink raw reply [flat|nested] 19+ messages in thread
end of thread, other threads:[~2012-02-01 16:35 UTC | newest] Thread overview: 19+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2012-01-08 20:56 [PATCH 0/3] s3c-hsudc powerdomain using generic power domains Heiko Stübner 2012-01-08 20:57 ` [PATCH 1/3] s3c-hsudc: Use helper functions instead of generic container_of Heiko Stübner 2012-01-24 9:36 ` Felipe Balbi 2012-01-08 20:58 ` [PATCH 2/3] s3c-hsudc: add basic runtime_pm calls Heiko Stübner 2012-01-24 9:37 ` Felipe Balbi 2012-01-08 20:59 ` [PATCH 3/3] S3C2443: add power domain for usb phy Heiko Stübner 2012-01-24 9:38 ` Felipe Balbi 2012-01-24 9:50 ` Heiko Stübner 2012-01-24 9:51 ` Felipe Balbi 2012-01-24 10:09 ` Heiko Stübner 2012-01-24 10:12 ` Felipe Balbi 2012-01-24 10:13 ` Heiko Stübner 2012-01-24 10:15 ` Felipe Balbi 2012-01-24 10:31 ` Heiko Stübner 2012-01-24 13:01 ` Kukjin Kim 2012-01-24 13:07 ` Felipe Balbi 2012-01-24 13:27 ` Heiko Stübner 2012-01-24 13:30 ` Felipe Balbi 2012-02-01 16:35 ` Heiko Stübner
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).