linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 21/31] ARM: amba: realview: get rid of private platform amba_device initializer
Date: Thu, 26 Jan 2012 17:25:27 +0000	[thread overview]
Message-ID: <20120126172527.GA12731@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120125110647.GV16726@n2100.arm.linux.org.uk>

On Wed, Jan 25, 2012 at 11:06:47AM +0000, Russell King - ARM Linux wrote:
> Right, so with the stack of amba patches on top, it looks like this,
> which to me looks sane.  I haven't build-tested it though.

Will,

Did you see this?  Any comment?

Thanks.

> 
> diff --git a/arch/arm/mach-realview/include/mach/irqs-pb1176.h b/arch/arm/mach-realview/include/mach/irqs-pb1176.h
> index 5c3c625..708f841 100644
> --- a/arch/arm/mach-realview/include/mach/irqs-pb1176.h
> +++ b/arch/arm/mach-realview/include/mach/irqs-pb1176.h
> @@ -40,6 +40,7 @@
>  #define IRQ_DC1176_L2CC		(IRQ_DC1176_GIC_START + 13)
>  #define IRQ_DC1176_RTC		(IRQ_DC1176_GIC_START + 14)
>  #define IRQ_DC1176_CLCD		(IRQ_DC1176_GIC_START + 15)	/* CLCD controller */
> +#define IRQ_DC1176_GPIO0	(IRQ_DC1176_GIC_START + 16)
>  #define IRQ_DC1176_SSP		(IRQ_DC1176_GIC_START + 17)	/* SSP port */
>  #define IRQ_DC1176_UART0	(IRQ_DC1176_GIC_START + 18)	/* UART 0 on development chip */
>  #define IRQ_DC1176_UART1	(IRQ_DC1176_GIC_START + 19)	/* UART 1 on development chip */
> @@ -73,7 +74,6 @@
>  #define IRQ_PB1176_DMAC		(IRQ_PB1176_GIC_START + 24)	/* DMA controller */
>  #define IRQ_PB1176_RTC		(IRQ_PB1176_GIC_START + 25)	/* Real Time Clock */
>  
> -#define IRQ_PB1176_GPIO0	-1
>  #define IRQ_PB1176_SCTL		-1
>  
>  #define NR_GIC_PB1176		2
> diff --git a/arch/arm/mach-realview/realview_pb1176.c b/arch/arm/mach-realview/realview_pb1176.c
> index 1b6e60c..b1d7caf 100644
> --- a/arch/arm/mach-realview/realview_pb1176.c
> +++ b/arch/arm/mach-realview/realview_pb1176.c
> @@ -143,7 +143,7 @@ static struct pl022_ssp_controller ssp0_plat_data = {
>  #define PB1176_CLCD_IRQ	{ IRQ_DC1176_CLCD }
>  #define SCTL_IRQ	{ }
>  #define PB1176_WATCHDOG_IRQ	{ IRQ_DC1176_WATCHDOG }
> -#define PB1176_GPIO0_IRQ	{ IRQ_PB1176_GPIO0 }
> +#define PB1176_GPIO0_IRQ	{ IRQ_DC1176_GPIO0 }
>  #define GPIO1_IRQ	{ IRQ_PB1176_GPIO1 }
>  #define PB1176_RTC_IRQ	{ IRQ_DC1176_RTC }
>  #define SCI_IRQ		{ IRQ_PB1176_SCI }
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2012-01-26 17:25 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-20  9:22 [PATCH 00/31] Clean up amba/primecell bus support Russell King - ARM Linux
2012-01-20  9:22 ` [PATCH 01/31] ARM: amba: add amba_device allocation/add/put functions Russell King - ARM Linux
2012-01-20  9:23 ` [PATCH 02/31] ARM: amba: of: convert to use amba_device_alloc Russell King - ARM Linux
2012-01-20 13:58   ` Rob Herring
2012-01-20  9:23 ` [PATCH 03/31] ARM: amba: ux500: " Russell King - ARM Linux
2012-01-21 16:21   ` Srinidhi KASAGAR
2012-01-23 19:03   ` Linus Walleij
2012-01-20  9:23 ` [PATCH 04/31] ARM: amba: integrator: " Russell King - ARM Linux
2012-01-20  9:24 ` [PATCH 05/31] ARM: amba: mxs: " Russell King - ARM Linux
2012-01-20 12:25   ` Shawn Guo
2012-01-20 12:39     ` Russell King - ARM Linux
2012-01-20  9:24 ` [PATCH 06/31] ARM: amba: make irq 0 invalid Russell King - ARM Linux
2012-01-20  9:24 ` [PATCH 07/31] ARM: amba: ux500: get rid of NO_IRQ Russell King - ARM Linux
2012-01-21 16:19   ` Srinidhi KASAGAR
2012-01-23 19:04   ` Linus Walleij
2012-01-20  9:25 ` [PATCH 08/31] ARM: amba: get rid of NO_IRQ initializers Russell King - ARM Linux
2012-01-20  9:25 ` [PATCH 09/31] ARM: amba: samsung: " Russell King - ARM Linux
2012-01-21  0:28   ` Kukjin Kim
2012-01-20  9:25 ` [PATCH 10/31] ARM: amba: integrator/realview/versatile/vexpress: " Russell King - ARM Linux
2012-01-20  9:26 ` [PATCH 11/31] ARM: amba: lpc32xx: " Russell King - ARM Linux
2012-01-20  9:26 ` [PATCH 12/31] ARM: amba: mxs: " Russell King - ARM Linux
2012-01-20 12:27   ` Shawn Guo
2012-01-20  9:26 ` [PATCH 13/31] ARM: amba: nomadik: " Russell King - ARM Linux
2012-01-23 19:02   ` Linus Walleij
2012-01-20  9:27 ` [PATCH 14/31] ARM: amba: netx: " Russell King - ARM Linux
2012-01-20  9:27 ` [PATCH 15/31] ARM: amba: spear: " Russell King - ARM Linux
2012-01-20  9:30   ` Viresh Kumar
2012-01-20  9:27 ` [PATCH 16/31] ARM: amba: u300: " Russell King - ARM Linux
2012-01-23 19:04   ` Linus Walleij
2012-01-20  9:28 ` [PATCH 17/31] ARM: amba: make use of -1 IRQs warn Russell King - ARM Linux
2012-01-20  9:28 ` [PATCH 18/31] ARM: amba: provide common initializers for static amba devices Russell King - ARM Linux
2012-01-20 17:58   ` H Hartley Sweeten
2012-01-20  9:28 ` [PATCH 19/31] ARM: amba: vexpress: get rid of private platform amba_device initializer Russell King - ARM Linux
2012-01-24 14:27   ` Will Deacon
2012-01-20  9:29 ` [PATCH 20/31] ARM: amba: versatile: " Russell King - ARM Linux
2012-01-24 15:06   ` Will Deacon
2012-01-20  9:29 ` [PATCH 21/31] ARM: amba: realview: " Russell King - ARM Linux
2012-01-24 16:00   ` Will Deacon
2012-01-24 16:23     ` Russell King - ARM Linux
2012-01-24 17:26       ` Will Deacon
2012-01-24 21:23         ` Linus Walleij
2012-01-24 21:45         ` Russell King - ARM Linux
2012-01-25  9:58           ` Will Deacon
2012-01-25 10:22             ` Russell King - ARM Linux
2012-01-25 10:39               ` Will Deacon
2012-01-25 11:06                 ` Russell King - ARM Linux
2012-01-26 17:25                   ` Russell King - ARM Linux [this message]
2012-01-26 17:37                     ` Will Deacon
2012-01-26 17:41                       ` Russell King - ARM Linux
2012-01-20  9:29 ` [PATCH 22/31] ARM: amba: integrator: use common amba device initializers Russell King - ARM Linux
2012-01-24 16:13   ` Will Deacon
2012-01-20  9:30 ` [PATCH 23/31] ARM: amba: omap2: " Russell King - ARM Linux
2012-01-20 14:37   ` Tony Lindgren
2012-01-20  9:30 ` [PATCH 24/31] ARM: amba: ep93xx: " Russell King - ARM Linux
2012-01-20 16:56   ` H Hartley Sweeten
2012-01-20  9:30 ` [PATCH 25/31] ARM: amba: bcmring: " Russell King - ARM Linux
2012-01-20  9:31 ` [PATCH 26/31] ARM: amba: netx: " Russell King - ARM Linux
2012-01-20  9:31 ` [PATCH 27/31] ARM: amba: lpc32xx: " Russell King - ARM Linux
2012-01-20  9:31 ` [PATCH 28/31] ARM: amba: u300: " Russell King - ARM Linux
2012-01-23 19:05   ` Linus Walleij
2012-01-20  9:32 ` [PATCH 29/31] ARM: amba: nomadik: " Russell King - ARM Linux
2012-01-23 19:02   ` Linus Walleij
2012-01-20  9:32 ` [PATCH 30/31] ARM: amba: spear: " Russell King - ARM Linux
2012-01-20  9:38   ` Viresh Kumar
2012-01-20  9:32 ` [PATCH 31/31] ARM: amba: samsung: " Russell King - ARM Linux
2012-01-21  0:45   ` Kukjin Kim
2012-01-20 22:33 ` [PATCH 13/31] ARM: amba: nomadik: get rid of NO_IRQ initializers Alessandro Rubini
2012-01-20 22:33 ` [PATCH 29/31] ARM: amba: nomadik: use common amba device initializers Alessandro Rubini
2012-01-21  0:59 ` [PATCH 00/31] Clean up amba/primecell bus support Kukjin Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120126172527.GA12731@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).