From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: id: Add missing break statement in omap3xxx_check_revision
Date: Thu, 26 Jan 2012 16:25:43 -0800 [thread overview]
Message-ID: <20120127002543.GG29812@atomide.com> (raw)
In-Reply-To: <1327305407-19914-1-git-send-email-hvaibhav@ti.com>
* Vaibhav Hiremath <hvaibhav@ti.com> [120122 23:26]:
> Add missing break statement in the function omap3xxx_check_revision.
>
> The commit id 4390f5b2cb1f56 [ARM: OMAP: TI814X: Add cpu type macros
> and detection support], removed the 'break' statement from the function
> omap3xxx_check_revision(), resulting into wrong omap/cpu_revision
> initialization for AM335x devices.
Looks like this is already fixed, can you please verify with
v3.3-rc1?
Regards,
Tony
> Signed-off-by: Vaibhav Hiremath <hvaibhav@ti.com>
> Cc: Tony Lindgren <tony@atomide.com>
> ---
> arch/arm/mach-omap2/id.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/id.c b/arch/arm/mach-omap2/id.c
> index 325e12e..32cf203 100644
> --- a/arch/arm/mach-omap2/id.c
> +++ b/arch/arm/mach-omap2/id.c
> @@ -395,6 +395,7 @@ void __init omap3xxx_check_revision(void)
> case 0xb944:
> omap_revision = AM335X_REV_ES1_0;
> cpu_rev = "1.0";
> + break;
> case 0xb8f2:
> switch (rev) {
> case 0:
> --
> 1.7.0.4
>
next prev parent reply other threads:[~2012-01-27 0:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 7:56 [PATCH] ARM: OMAP: id: Add missing break statement in omap3xxx_check_revision Vaibhav Hiremath
2012-01-27 0:25 ` Tony Lindgren [this message]
2012-01-27 5:32 ` Hiremath, Vaibhav
2012-01-30 8:30 ` Hiremath, Vaibhav
2012-02-29 22:42 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120127002543.GG29812@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).