linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ARM: S3C64XX: Fix mismerge of Littemill device in Cragganmore
@ 2012-01-24 21:04 Mark Brown
  2012-01-27  1:33 ` Kukjin Kim
  0 siblings, 1 reply; 3+ messages in thread
From: Mark Brown @ 2012-01-24 21:04 UTC (permalink / raw)
  To: linux-arm-kernel

The -next s3c64xx tree appears to have acquired a duplicate copy of
the commit adding Littlemill which is already in mainline causing two
copies of the device definition to be in the code. Either the duplicate
should be dropped or this commit should be applied on top of it to remove
one of the duplicates.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 arch/arm/mach-s3c64xx/mach-crag6410.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c b/arch/arm/mach-s3c64xx/mach-crag6410.c
index fe7f3be..d5a7982 100644
--- a/arch/arm/mach-s3c64xx/mach-crag6410.c
+++ b/arch/arm/mach-s3c64xx/mach-crag6410.c
@@ -299,11 +299,6 @@ static struct platform_device littlemill_device = {
 	.id		= -1,
 };
 
-static struct platform_device littlemill_device = {
-	.name		= "littlemill",
-	.id		= -1,
-};
-
 static struct regulator_consumer_supply wallvdd_consumers[] = {
 	REGULATOR_SUPPLY("SPKVDD", "1-001a"),
 	REGULATOR_SUPPLY("SPKVDD1", "1-001a"),
-- 
1.7.9.rc1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [PATCH] ARM: S3C64XX: Fix mismerge of Littemill device in Cragganmore
  2012-01-24 21:04 [PATCH] ARM: S3C64XX: Fix mismerge of Littemill device in Cragganmore Mark Brown
@ 2012-01-27  1:33 ` Kukjin Kim
  2012-01-27 11:18   ` Mark Brown
  0 siblings, 1 reply; 3+ messages in thread
From: Kukjin Kim @ 2012-01-27  1:33 UTC (permalink / raw)
  To: linux-arm-kernel

Mark Brown wrote:
> 
> The -next s3c64xx tree appears to have acquired a duplicate copy of
> the commit adding Littlemill which is already in mainline causing two
> copies of the device definition to be in the code. Either the duplicate
> should be dropped or this commit should be applied on top of it to remove
> one of the duplicates.
> 

Mark, maybe the duplication commit has been fixed now -next. I can't find it
now. So I think, we can drop this. If any other problems, please kindly let
me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.


> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
>  arch/arm/mach-s3c64xx/mach-crag6410.c |    5 -----
>  1 files changed, 0 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-s3c64xx/mach-crag6410.c b/arch/arm/mach-
> s3c64xx/mach-crag6410.c
> index fe7f3be..d5a7982 100644
> --- a/arch/arm/mach-s3c64xx/mach-crag6410.c
> +++ b/arch/arm/mach-s3c64xx/mach-crag6410.c
> @@ -299,11 +299,6 @@ static struct platform_device littlemill_device = {
>  	.id		= -1,
>  };
> 
> -static struct platform_device littlemill_device = {
> -	.name		= "littlemill",
> -	.id		= -1,
> -};
> -
>  static struct regulator_consumer_supply wallvdd_consumers[] = {
>  	REGULATOR_SUPPLY("SPKVDD", "1-001a"),
>  	REGULATOR_SUPPLY("SPKVDD1", "1-001a"),
> --
> 1.7.9.rc1

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [PATCH] ARM: S3C64XX: Fix mismerge of Littemill device in Cragganmore
  2012-01-27  1:33 ` Kukjin Kim
@ 2012-01-27 11:18   ` Mark Brown
  0 siblings, 0 replies; 3+ messages in thread
From: Mark Brown @ 2012-01-27 11:18 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Jan 27, 2012 at 10:33:56AM +0900, Kukjin Kim wrote:

> Mark, maybe the duplication commit has been fixed now -next. I can't find it
> now. So I think, we can drop this. If any other problems, please kindly let
> me know.

Yes, it seems to have been sorted at some point.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2012-01-27 11:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-24 21:04 [PATCH] ARM: S3C64XX: Fix mismerge of Littemill device in Cragganmore Mark Brown
2012-01-27  1:33 ` Kukjin Kim
2012-01-27 11:18   ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).