From: grant.likely@secretlab.ca (Grant Likely)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] ARM: at91/tc: add device tree support to atmel_tclib
Date: Sat, 28 Jan 2012 11:29:47 -0700 [thread overview]
Message-ID: <20120128182947.GA4053@ponder.secretlab.ca> (raw)
In-Reply-To: <185a4d609becfcd60bbd15b09612160cf6ea9346.1326995849.git.nicolas.ferre@atmel.com>
On Thu, Jan 19, 2012 at 07:05:11PM +0100, Nicolas Ferre wrote:
> Device tree support added to atmel_tclib: the generic Timer Counter
> library. This is used by the clocksource/clockevent driver tcb_clksrc.
>
> The current DT enabled platforms are also modified to use it:
> - .dtsi files are modified to add Timer Counter Block entries
> - alias are created to allow identification of each block
> - clkdev lookup tables are added for clocks identification.
>
> Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com>
...
> diff --git a/arch/arm/mach-at91/at91sam9g45_devices.c b/arch/arm/mach-at91/at91sam9g45_devices.c
> index 545bbe9..a0a217d 100644
> --- a/arch/arm/mach-at91/at91sam9g45_devices.c
> +++ b/arch/arm/mach-at91/at91sam9g45_devices.c
> @@ -995,8 +995,25 @@ static struct platform_device at91sam9g45_tcb1_device = {
> .num_resources = ARRAY_SIZE(tcb1_resources),
> };
>
> +#if defined(CONFIG_OF)
> +static struct of_device_id tcb_ids[] = {
> + { .compatible = "atmel,at91rm9200-tcb" },
> + { /*sentinel*/ }
> +};
> +#endif
> +
Where is the documentation for this new binding? Every new binding must
be documented in Documentation/devicetree/bindings, even if it is just a
short file listing all the trivial (only reg and irq) bindings used by
atmel devices.
Otherwise this looks fine and you can add my Acked-by:
g.
next prev parent reply other threads:[~2012-01-28 18:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 18:05 [PATCH 0/3] ARM: at91/tc: DT support Nicolas Ferre
2012-01-19 18:05 ` [PATCH 1/3] ARM: at91/tclib: take iomem size from resource Nicolas Ferre
2012-01-28 7:01 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-19 18:05 ` [PATCH 2/3] ARM: at91/tc: add device tree support to atmel_tclib Nicolas Ferre
2012-01-28 18:29 ` Grant Likely [this message]
2012-01-19 18:05 ` [PATCH 3/3] ARM: at91/tc/clocksource: Add 32 bit variant to Timer Counter Nicolas Ferre
2012-01-28 7:01 ` Jean-Christophe PLAGNIOL-VILLARD
2012-01-28 18:31 ` Grant Likely
2012-01-31 11:08 ` ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120128182947.GA4053@ponder.secretlab.ca \
--to=grant.likely@secretlab.ca \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).