[PATCH 1/2] ARM: OMAP3: PM: remove superfluous calls to pwrdm_clear_all_prev_pwrst()

Rajendra Nayak
2012-01-31T03:53:04Z

On Tuesday 31 January 2012 05:44 AM, Kevin Hilman wrote:
> Paul Walmsley<paul@pwsan.com> writes:
>
>> Remove some superfluous calls to pwrdm_clear_all_prev_pwrst().
>> pwrdm_pre_transition(), which appears a few lines after these calls,
>> invokes pwrdm_clear_all_prev_pwrst() on each powerdomain -- there's no
>> need to do it twice.
>
> It looks like these two for OMAP4 are surpurfluous since the immediately
> follow a call to pwrdm_pre_transition() as well.
>
> Santosh/Rajendra, please confirm/ack.

I agree, looks like they should be removed.
Acked-by: Rajendra Nayak <rnayak@ti.com>

>
> Kevin
>
>
> diff --git a/arch/arm/mach-omap2/omap-mpuss-lowpower.c b/arch/arm/mach-omap2/omap-mpuss-lowpower.c
> index 1d5d010..bbabe1d 100644
> --- a/arch/arm/mach-omap2/omap-mpuss-lowpower.c
> +++ b/arch/arm/mach-omap2/omap-mpuss-lowpower.c
> @@ -263,12 +263,10 @@ int omap4_enter_lowpower(unsigned int cpu, unsigned int power_state)
> * In MPUSS OSWR or device OFF, interrupt controller contest is lost.
> */
> mpuss_clear_prev_logic_pwrst();
> - pwrdm_clear_all_prev_pwrst(mpuss_pd);
> if ((pwrdm_read_next_pwrst(mpuss_pd) == PWRDM_POWER_RET)&&
> (pwrdm_read_logic_retst(mpuss_pd) == PWRDM_POWER_OFF))
> save_state = 2;
>
> - clear_cpu_prev_pwrst(cpu);
> cpu_clear_prev_logic_pwrst(cpu);
> set_cpu_next_pwrst(cpu, power_state);
> set_cpu_wakeup_addr(cpu, virt_to_phys(omap4_cpu_resume));