[PATCH 2/2] ARM: OMAP2+: PM: clean up omap_set_pwrdm_state()

Rajendra Nayak
2012-01-31T03:46:56Z

Hi Paul,

On Monday 30 January 2012 03:13 PM, Paul Walmsley wrote:
> Clean up a few different parts of omap_set_pwrdm_state():
>
> - Remove a superfluous call to pwrdm_state_switch(). Not needed
> unless LOWPOWERSTATECHANGE is used, because the state switch code is
> called by either clkdm_sleep() or clkdm_allow_idle().
>
> - Add code to wait for the power state transition in the OMAP4+ low
> power state change. This is speculative, so I would particularly
> appreciate feedback on this part.
>
> - Remove a superfluous call to pwrdm_read_pwrst().
>
> - Update variable names to be more meaningful (hopefully) and precise.
>
> - Fix an error path bug that would not place the clockdomain back into
> hardware-supervised idle or sleep mode if the power state could not
> be programmed.

All the changes look good. Thanks.
Acked-by: Rajendra Nayak <rnayak@ti.com>

regards,
Rajendra

>