From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] LPC32XX build fix
Date: Tue, 31 Jan 2012 11:10:07 +0100 [thread overview]
Message-ID: <20120131101007.GD2471@pengutronix.de> (raw)
In-Reply-To: <1327669485-15322-1-git-send-email-stigge@antcom.de>
On Fri, Jan 27, 2012 at 02:04:45PM +0100, Roland Stigge wrote:
> This patch fixes a GCC compile error ("static declaration follows non-static
> declaration") for LPC32XX's watchdog, removing the extern declaration since
> it's not called externally.
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
Subject header should contain "arm: lpc32xx" and describe the fix like
"remove broken non-static declaration" or so
Other than that:
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
>
> diff --git a/arch/arm/mach-lpc32xx/common.h b/arch/arm/mach-lpc32xx/common.h
> index 4b4e700..75640bfb 100644
> --- a/arch/arm/mach-lpc32xx/common.h
> +++ b/arch/arm/mach-lpc32xx/common.h
> @@ -65,7 +65,6 @@ extern u32 clk_get_pclk_div(void);
> */
> extern void lpc32xx_get_uid(u32 devid[4]);
>
> -extern void lpc32xx_watchdog_reset(void);
> extern u32 lpc32xx_return_iram_size(void);
>
> /*
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120131/14f9ff59/attachment.sig>
next prev parent reply other threads:[~2012-01-31 10:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-27 13:04 [PATCH] LPC32XX build fix Roland Stigge
2012-01-31 10:10 ` Wolfram Sang [this message]
2012-01-31 16:14 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131101007.GD2471@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).