* [PATCH] LPC32XX build fix
@ 2012-01-27 13:04 Roland Stigge
2012-01-31 10:10 ` Wolfram Sang
2012-01-31 16:14 ` Grant Likely
0 siblings, 2 replies; 3+ messages in thread
From: Roland Stigge @ 2012-01-27 13:04 UTC (permalink / raw)
To: linux-arm-kernel
This patch fixes a GCC compile error ("static declaration follows non-static
declaration") for LPC32XX's watchdog, removing the extern declaration since
it's not called externally.
Signed-off-by: Roland Stigge <stigge@antcom.de>
diff --git a/arch/arm/mach-lpc32xx/common.h b/arch/arm/mach-lpc32xx/common.h
index 4b4e700..75640bfb 100644
--- a/arch/arm/mach-lpc32xx/common.h
+++ b/arch/arm/mach-lpc32xx/common.h
@@ -65,7 +65,6 @@ extern u32 clk_get_pclk_div(void);
*/
extern void lpc32xx_get_uid(u32 devid[4]);
-extern void lpc32xx_watchdog_reset(void);
extern u32 lpc32xx_return_iram_size(void);
/*
^ permalink raw reply related [flat|nested] 3+ messages in thread* [PATCH] LPC32XX build fix
2012-01-27 13:04 [PATCH] LPC32XX build fix Roland Stigge
@ 2012-01-31 10:10 ` Wolfram Sang
2012-01-31 16:14 ` Grant Likely
1 sibling, 0 replies; 3+ messages in thread
From: Wolfram Sang @ 2012-01-31 10:10 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 27, 2012 at 02:04:45PM +0100, Roland Stigge wrote:
> This patch fixes a GCC compile error ("static declaration follows non-static
> declaration") for LPC32XX's watchdog, removing the extern declaration since
> it's not called externally.
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
Subject header should contain "arm: lpc32xx" and describe the fix like
"remove broken non-static declaration" or so
Other than that:
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
>
> diff --git a/arch/arm/mach-lpc32xx/common.h b/arch/arm/mach-lpc32xx/common.h
> index 4b4e700..75640bfb 100644
> --- a/arch/arm/mach-lpc32xx/common.h
> +++ b/arch/arm/mach-lpc32xx/common.h
> @@ -65,7 +65,6 @@ extern u32 clk_get_pclk_div(void);
> */
> extern void lpc32xx_get_uid(u32 devid[4]);
>
> -extern void lpc32xx_watchdog_reset(void);
> extern u32 lpc32xx_return_iram_size(void);
>
> /*
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120131/14f9ff59/attachment.sig>
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH] LPC32XX build fix
2012-01-27 13:04 [PATCH] LPC32XX build fix Roland Stigge
2012-01-31 10:10 ` Wolfram Sang
@ 2012-01-31 16:14 ` Grant Likely
1 sibling, 0 replies; 3+ messages in thread
From: Grant Likely @ 2012-01-31 16:14 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Jan 27, 2012 at 6:04 AM, Roland Stigge <stigge@antcom.de> wrote:
> This patch fixes a GCC compile error ("static declaration follows non-static
> declaration") for LPC32XX's watchdog, removing the extern declaration since
> it's not called externally.
>
> Signed-off-by: Roland Stigge <stigge@antcom.de>
>
> diff --git a/arch/arm/mach-lpc32xx/common.h b/arch/arm/mach-lpc32xx/common.h
> index 4b4e700..75640bfb 100644
> --- a/arch/arm/mach-lpc32xx/common.h
> +++ b/arch/arm/mach-lpc32xx/common.h
No need to CC me on patches like this. I'm not in any way involved
with lpc32xx maintainership.
g.
> @@ -65,7 +65,6 @@ extern u32 clk_get_pclk_div(void);
> ?*/
> ?extern void lpc32xx_get_uid(u32 devid[4]);
>
> -extern void lpc32xx_watchdog_reset(void);
> ?extern u32 lpc32xx_return_iram_size(void);
>
> ?/*
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-31 16:14 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-01-27 13:04 [PATCH] LPC32XX build fix Roland Stigge
2012-01-31 10:10 ` Wolfram Sang
2012-01-31 16:14 ` Grant Likely
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).