From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mxs: read correct values when setting up MAC
Date: Tue, 31 Jan 2012 15:21:55 +0100 [thread overview]
Message-ID: <20120131142155.GQ2471@pengutronix.de> (raw)
In-Reply-To: <1327431447-5031-1-git-send-email-w.sang@pengutronix.de>
On Tue, Jan 24, 2012 at 07:57:27PM +0100, Wolfram Sang wrote:
> Currently, the MAC address from the second ethernet is generated from the
> crypto-key (and not a customer reg) because of a wrong index to the ocotp
> array.
>
> Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> Cc: Shawn Guo <shawn.guo@linaro.org>
> Cc: Stefano Babic <sbabic@denx.de>
> ---
Ping.
>
> This looks clearly wrong to me; probably ocotp was a u8 somewhen in the
> process? I wonder how it works for these boards. Am I missing something?
>
> arch/arm/mach-mxs/mach-m28evk.c | 2 +-
> arch/arm/mach-mxs/mach-mx28evk.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-mxs/mach-m28evk.c b/arch/arm/mach-mxs/mach-m28evk.c
> index 2f27582..8d1459d 100644
> --- a/arch/arm/mach-mxs/mach-m28evk.c
> +++ b/arch/arm/mach-mxs/mach-m28evk.c
> @@ -258,7 +258,7 @@ static int __init m28evk_fec_get_mac(void)
> * so hard-code DENX OUI (C0:E5:4E) here.
> */
> for (i = 0; i < 2; i++) {
> - val = ocotp[i * 4];
> + val = ocotp[i];
> mx28_fec_pdata[i].mac[0] = 0xC0;
> mx28_fec_pdata[i].mac[1] = 0xE5;
> mx28_fec_pdata[i].mac[2] = 0x4E;
> diff --git a/arch/arm/mach-mxs/mach-mx28evk.c b/arch/arm/mach-mxs/mach-mx28evk.c
> index fdb0a56..df318ef 100644
> --- a/arch/arm/mach-mxs/mach-mx28evk.c
> +++ b/arch/arm/mach-mxs/mach-mx28evk.c
> @@ -285,7 +285,7 @@ static int __init mx28evk_fec_get_mac(void)
> * so hard-code Freescale OUI (00:04:9f) here.
> */
> for (i = 0; i < 2; i++) {
> - val = ocotp[i * 4];
> + val = ocotp[i];
> mx28_fec_pdata[i].mac[0] = 0x00;
> mx28_fec_pdata[i].mac[1] = 0x04;
> mx28_fec_pdata[i].mac[2] = 0x9f;
> --
> 1.7.2.5
>
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120131/57fff6c3/attachment.sig>
next prev parent reply other threads:[~2012-01-31 14:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-24 18:57 [PATCH] ARM: mxs: read correct values when setting up MAC Wolfram Sang
2012-01-25 14:49 ` Stefano Babic
2012-01-25 15:35 ` Wolfram Sang
2012-01-25 16:12 ` Stefano Babic
2012-01-31 14:21 ` Wolfram Sang [this message]
2012-01-31 15:21 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120131142155.GQ2471@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).