linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm: omap3: cm-t35: fix section mismatch warning
Date: Tue, 7 Feb 2012 21:35:57 -0800	[thread overview]
Message-ID: <20120208053556.GB1426@atomide.com> (raw)
In-Reply-To: <1328441980-28892-1-git-send-email-grinberg@compulab.co.il>

* Igor Grinberg <grinberg@compulab.co.il> [120205 03:08]:
> WARNING: arch/arm/mach-omap2/built-in.o(.text+0xeae8):
> Section mismatch in reference from the function cm_t35_init_usbh()
> to the (unknown reference) .init.data:(unknown)
> The function cm_t35_init_usbh() references
> the (unknown reference) __initdata (unknown).
> This is often because cm_t35_init_usbh lacks a __initdata
> annotation or the annotation of (unknown) is wrong.
> 
> Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
> ---
> Sorry about this one. I fixed similar problem for cm-t3517 a while ago,
> but somehow missed cm-t35. Thanks for spotting.
> Probably enabling the CONFIG_DEBUG_SECTION_MISMATCH in defconfigs
> can raise people awareness for this.

Thanks applying into fixes. Yes let's plan on doing that,
and also make sure we're actually seeing the warnings..

Tony
 
>  arch/arm/mach-omap2/board-cm-t35.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/board-cm-t35.c b/arch/arm/mach-omap2/board-cm-t35.c
> index d839c05..a8cedbe 100644
> --- a/arch/arm/mach-omap2/board-cm-t35.c
> +++ b/arch/arm/mach-omap2/board-cm-t35.c
> @@ -436,7 +436,7 @@ static struct usbhs_omap_board_data usbhs_bdata __initdata = {
>  	.reset_gpio_port[2]  = -EINVAL
>  };
>  
> -static void cm_t35_init_usbh(void)
> +static void  __init cm_t35_init_usbh(void)
>  {
>  	int err;
>  
> -- 
> 1.7.3.4
> 

  reply	other threads:[~2012-02-08  5:35 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20120205012556.GG1426@atomide.com>
2012-02-05 11:39 ` [PATCH] arm: omap3: cm-t35: fix section mismatch warning Igor Grinberg
2012-02-08  5:35   ` Tony Lindgren [this message]
2012-02-08 10:16     ` [PATCH] ARM: OMAP: update omap1 and omap2plus defconfigs Igor Grinberg
2012-02-08 10:19       ` Russell King - ARM Linux
2012-02-08 11:09         ` Igor Grinberg
2012-02-08 19:51         ` Tony Lindgren
2012-02-08 15:37       ` Janusz Krzysztofik
2012-02-09 11:18       ` [PATCH] ARM: OMAP1: ams-delta: clean up init data section assignments Janusz Krzysztofik
2012-02-09 14:48         ` Russell King - ARM Linux
2012-02-10 16:31           ` [PATCH] ARM: OMAP1: ams-delta: correct " Janusz Krzysztofik
2012-02-10 16:48             ` [PATCH v2] ARM: OMAP1: ams-delta: clean up " Janusz Krzysztofik
2012-02-11 10:24             ` [PATCH] ARM: OMAP1: ams-delta: correct " Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120208053556.GB1426@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).