From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] DMA: PL330: Merge PL330 driver into drivers/dma/
Date: Wed, 8 Feb 2012 08:46:49 +0000 [thread overview]
Message-ID: <20120208084649.GF889@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <003101cce5fe$734b9990$59e2ccb0$%kim@samsung.com>
On Wed, Feb 08, 2012 at 10:10:30AM +0900, Boojin Kim wrote:
> Russell King - ARM Linux wrote:
> >
> > Now that the PL330 code is entirely out of arch/arm, the header should no
> > longer be in asm/hardware/pl330.h.
> >
> > Definitions private to the driver should be in drivers/dma/pl330.c or a
> > header file co-located. Other definitions for interfaces to that driver
> > (eg, platform data) should be in include/linux/amba.
> >
> > That can be the subject of a follow-up patch if this is already finalized.
> >
> Sorry to late response. I believed my reply was sent. But, It maybe be not.
> Anyway.. get to the point.
> Pl08x also has asm/hardware/pl080.h to include hw specific information.
History basically.
> It seems to be same purpose with asm/hardware/pl330.h
> Do you mean both asm/hardware/pl080.h and asm/hardware/pl330.h should be
> moved to include/linux/amba?
No. asm/hardware/pl330.h Should go into drivers/dma if nothing but the
PL330 DMA driver in there needs it.
Same for pl080.h but as your patches isn't touching that, then that's not
something that should be done separately.
next prev parent reply other threads:[~2012-02-08 8:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-12 1:51 [PATCH v2 1/2] DMA: PL330: Merge PL330 driver into drivers/dma/ Boojin Kim
2012-01-05 14:54 ` Russell King - ARM Linux
2012-01-06 1:47 ` Kukjin Kim
2012-02-08 1:10 ` Boojin Kim
2012-02-08 8:46 ` Russell King - ARM Linux [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-12-15 1:08 [PATCH V2 " Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120208084649.GF889@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).