public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH 3.3] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined
@ 2012-02-08 10:59 Luciano Coelho
  2012-02-08 11:03 ` Felipe Balbi
  2012-02-08 11:50 ` Sergei Shtylyov
  0 siblings, 2 replies; 4+ messages in thread
From: Luciano Coelho @ 2012-02-08 10:59 UTC (permalink / raw)
  To: linux-arm-kernel

Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:

arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1

This is because of a missing include, which is added indirectly if
CONFIG_OF is defined.  This problem was introduced in commit
2f31b51659c2d8315ea2888ba5b93076febe672b

Cc: Tero Kristo <t-kristo@ti.com>
Signed-off-by: Luciano Coelho <coelho@ti.com>
---
 arch/arm/mach-omap2/prm44xx.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
index 33dd655..f2e06ad 100644
--- a/arch/arm/mach-omap2/prm44xx.c
+++ b/arch/arm/mach-omap2/prm44xx.c
@@ -20,6 +20,7 @@
 #include "common.h"
 #include <plat/cpu.h>
 #include <plat/prcm.h>
+#include <plat/irqs.h>
 
 #include "vp.h"
 #include "prm44xx.h"
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* [PATCH 3.3] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined
  2012-02-08 10:59 [PATCH 3.3] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined Luciano Coelho
@ 2012-02-08 11:03 ` Felipe Balbi
  2012-02-08 11:05   ` Luciano Coelho
  2012-02-08 11:50 ` Sergei Shtylyov
  1 sibling, 1 reply; 4+ messages in thread
From: Felipe Balbi @ 2012-02-08 11:03 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, Feb 08, 2012 at 12:59:12PM +0200, Luciano Coelho wrote:
> Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:
> 
> arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1
> 
> This is because of a missing include, which is added indirectly if
> CONFIG_OF is defined.  This problem was introduced in commit
> 2f31b51659c2d8315ea2888ba5b93076febe672b

same as previous patch. Abbreviated commit and commit subject.

> Cc: Tero Kristo <t-kristo@ti.com>
> Signed-off-by: Luciano Coelho <coelho@ti.com>

Reviewed-by: Felipe Balbi <balbi@ti.com>

> ---
>  arch/arm/mach-omap2/prm44xx.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/mach-omap2/prm44xx.c b/arch/arm/mach-omap2/prm44xx.c
> index 33dd655..f2e06ad 100644
> --- a/arch/arm/mach-omap2/prm44xx.c
> +++ b/arch/arm/mach-omap2/prm44xx.c
> @@ -20,6 +20,7 @@
>  #include "common.h"
>  #include <plat/cpu.h>
>  #include <plat/prcm.h>
> +#include <plat/irqs.h>
>  
>  #include "vp.h"
>  #include "prm44xx.h"
> -- 
> 1.7.5.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

-- 
balbi
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120208/7e7e7f0b/attachment.sig>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 3.3] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined
  2012-02-08 11:03 ` Felipe Balbi
@ 2012-02-08 11:05   ` Luciano Coelho
  0 siblings, 0 replies; 4+ messages in thread
From: Luciano Coelho @ 2012-02-08 11:05 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, 2012-02-08 at 13:03 +0200, Felipe Balbi wrote: 
> On Wed, Feb 08, 2012 at 12:59:12PM +0200, Luciano Coelho wrote:
> > Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:
> > 
> > arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
> > make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1
> > 
> > This is because of a missing include, which is added indirectly if
> > CONFIG_OF is defined.  This problem was introduced in commit
> > 2f31b51659c2d8315ea2888ba5b93076febe672b
> 
> same as previous patch. Abbreviated commit and commit subject.

Okay, I'll send v2 in a sec.

> > Cc: Tero Kristo <t-kristo@ti.com>
> > Signed-off-by: Luciano Coelho <coelho@ti.com>
> 
> Reviewed-by: Felipe Balbi <balbi@ti.com>

Thanks!

-- 
Cheers,
Luca.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH 3.3] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined
  2012-02-08 10:59 [PATCH 3.3] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined Luciano Coelho
  2012-02-08 11:03 ` Felipe Balbi
@ 2012-02-08 11:50 ` Sergei Shtylyov
  1 sibling, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2012-02-08 11:50 UTC (permalink / raw)
  To: linux-arm-kernel

Hello.

On 08-02-2012 14:59, Luciano Coelho wrote:

> Since 3.3-rc1, prm44xx.c build breaks if CONFIG_OF is not set:

> arch/arm/mach-omap2/prm44xx.c:41: error: 'OMAP44XX_IRQ_PRCM' undeclared here (not in a function)
> make[1]: *** [arch/arm/mach-omap2/prm44xx.o] Error 1

> This is because of a missing include, which is added indirectly if
> CONFIG_OF is defined.  This problem was introduced in commit
> 2f31b51659c2d8315ea2888ba5b93076febe672b

    Please also specify the summary of that commit in parens.

> Cc: Tero Kristo<t-kristo@ti.com>
> Signed-off-by: Luciano Coelho<coelho@ti.com>

WBR, Sergei

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2012-02-08 11:50 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-08 10:59 [PATCH 3.3] OMAP4: PRM: fix build breakage when CONFIG_OF is not defined Luciano Coelho
2012-02-08 11:03 ` Felipe Balbi
2012-02-08 11:05   ` Luciano Coelho
2012-02-08 11:50 ` Sergei Shtylyov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox