From mboxrd@z Thu Jan  1 00:00:00 1970
From: tony@atomide.com (Tony Lindgren)
Date: Wed, 8 Feb 2012 10:59:06 -0800
Subject: [PATCH 16/16] ARM: omap: disable cpuidle for OMAP3 platforms
In-Reply-To: <E1RvAZz-0006Hr-9C@rmk-PC.arm.linux.org.uk>
References: <20120208163546.GA15849@n2100.arm.linux.org.uk>
 <E1RvAZz-0006Hr-9C@rmk-PC.arm.linux.org.uk>
Message-ID: <20120208185905.GP29796@atomide.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

* Russell King - ARM Linux <linux@arm.linux.org.uk> [120208 08:10]:
> Commit 2fd149645eb4 (ARM: OMAP2+: UART: Remove omap_uart_can_sleep and add pm_qos)
> has caused a regression on OMAP3 platforms.
> 
> When the UART is trying to transmit data, if we enter a low power mode,
> transmission stops, which makes serial on OMAP3 unusable - a 'dmesg'
> takes five minutes to be output at 115200 baud, at a rate of around a
> block of 16 characters every couple of seconds.
> 
> Unfortunately, the commit above can't be reverted because of many other
> changes in this area, so this implements a dirty fix by disabling
> CPU idle in the places the original commit does, irrespective of the
> UART state.
...

> --- a/arch/arm/mach-omap2/pm34xx.c
> +++ b/arch/arm/mach-omap2/pm34xx.c
> @@ -421,7 +421,7 @@ static void omap3_pm_idle(void)
>  	local_irq_disable();
>  	local_fiq_disable();
>  
> -	if (omap_irq_pending() || need_resched())
> +	if (omap_irq_pending() || need_resched() || 1)
>  		goto out;
>  
>  	trace_power_start(POWER_CSTATE, 1, smp_processor_id());

Argh, this is just too ugly. There has got to be a better fix for the
-rc series.

Looks like the patches to fix omap-serial.c are queued for v3.4,
so that won't help.

Kevin, what do you have for the -rc fix here to avoid the if (1)
hack?

Regards,

Tony