From: davidb@codeaurora.org (David Brown)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v6 02/15] ARM: SoC: Add per SoC SMP and CPU hotplug operations
Date: Wed, 8 Feb 2012 17:28:40 -0800 [thread overview]
Message-ID: <20120209012840.GA19102@codeaurora.org> (raw)
In-Reply-To: <3d0d2b3f4a1ffda7057c55655404f696@localhost>
On Thu, Feb 09, 2012 at 02:00:48AM +0100, Marc Zyngier wrote:
>
> On Wed, 8 Feb 2012 15:42:53 -0800, David Brown <davidb@codeaurora.org>
> wrote:
> > On Wed, Feb 08, 2012 at 12:30:46AM +0000, Marc Zyngier wrote:
> >
> >> +#ifdef CONFIG_SMP
> >> +#define soc_smp_init_ops(ops) .smp_init_ops = &(ops),
> >> +#define soc_smp_ops(ops) .smp_ops = &(ops),
> >> +extern void soc_smp_ops_register(struct arm_soc_smp_init_ops *,
> >> + struct arm_soc_smp_ops *);
> >> +#else
> >> +#define soc_smp_init_ops(ops) /* empty */
> >> +#define soc_smp_ops(ops) /* empty */
> >> +#define soc_smp_ops_register(a,b) do {} while(0)
> >> +#endif
> >
> > I'm not sure if this bothers anyone else, but these macros mess up
> > editors that know how to indent C code, since the comma ends up inside
> > the macro. I'm not sure I have a better idea, though.
>
> Emacs seem quite happy when I wrote the code... Shall we re-open the
> editor war? ;-)
It is interesting that emacs gets it right (seem to use both emacs and
vi depending on my mood). I guess treating it as a function call
isn't valid C, so either interpretation in an editor is really right.
I guess just leave it. The structs are small, and it isn't too hard
lo fix things up. As I said earlier, I can't think of a better way to
do it.
Davi
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2012-02-09 1:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 0:30 [PATCH v6 00/15] Per SoC descriptor Marc Zyngier
2012-02-08 0:30 ` [PATCH v6 01/15] ARM: SoC: Introduce per " Marc Zyngier
2012-02-08 23:59 ` Nicolas Pitre
2012-02-08 0:30 ` [PATCH v6 02/15] ARM: SoC: Add per SoC SMP and CPU hotplug operations Marc Zyngier
2012-02-08 23:42 ` David Brown
2012-02-09 1:00 ` Marc Zyngier
2012-02-09 1:28 ` David Brown [this message]
2012-02-10 0:03 ` Arnd Bergmann
2012-02-09 0:02 ` Nicolas Pitre
2012-02-09 8:54 ` Russell King - ARM Linux
2012-02-08 0:30 ` [PATCH v6 03/15] ARM: SoC: convert VExpress/RealView to SoC descriptor Marc Zyngier
2012-02-08 0:30 ` [PATCH v6 04/15] ARM: SoC: convert OMAP4 " Marc Zyngier
2012-02-08 0:30 ` [PATCH v6 05/15] ARM: SoC: convert Tegra " Marc Zyngier
2012-02-08 0:30 ` [PATCH v6 06/15] ARM: SoC: convert Exynos4 " Marc Zyngier
2012-02-08 0:30 ` [PATCH v6 07/15] ARM: SoC: convert MSM SMP " Marc Zyngier
2012-02-08 23:39 ` David Brown
2012-02-08 23:42 ` Marc Zyngier
2012-02-08 0:30 ` [PATCH v6 08/15] ARM: SoC: convert ux500 " Marc Zyngier
2012-02-08 22:31 ` Linus Walleij
2012-02-09 5:29 ` Srinidhi KASAGAR
2012-02-08 0:30 ` [PATCH v6 09/15] ARM: SoC: convert shmobile SMP " Marc Zyngier
2012-02-08 0:30 ` [PATCH v6 10/15] ARM: SoC: convert highbank " Marc Zyngier
2012-02-08 0:30 ` [PATCH v6 11/15] ARM: SoC: convert imx6q " Marc Zyngier
2012-02-11 3:32 ` Shawn Guo
2012-02-08 0:30 ` [PATCH v6 12/15] ARM: smp: Make SoC descriptor mandatory for SMP platforms Marc Zyngier
2012-02-08 0:30 ` [PATCH v6 13/15] ARM: hotplug: Introduce dummy_cpu_kill Marc Zyngier
2012-02-09 0:16 ` Nicolas Pitre
2012-02-09 0:57 ` Marc Zyngier
2012-02-09 8:46 ` Russell King - ARM Linux
2012-02-09 22:48 ` Will Deacon
2012-02-08 0:30 ` [PATCH v6 14/15] ARM: hotplug: Introduce dummy_cpu_disable Marc Zyngier
2012-02-09 0:19 ` Nicolas Pitre
2012-02-08 0:30 ` [PATCH v6 15/15] ARM: hotplug: add cpu_lowpower as an alternative to cpu_die Marc Zyngier
2012-02-09 0:21 ` Nicolas Pitre
2012-02-09 8:48 ` Russell King - ARM Linux
2012-02-08 0:43 ` [PATCH v6 00/15] Per SoC descriptor Rob Herring
2012-02-08 0:49 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209012840.GA19102@codeaurora.org \
--to=davidb@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).