* hex number case in dts files.
@ 2012-02-09 18:04 David Brown
2012-02-09 18:20 ` Rob Herring
0 siblings, 1 reply; 6+ messages in thread
From: David Brown @ 2012-02-09 18:04 UTC (permalink / raw)
To: linux-arm-kernel
I've noticed an inconsistency in the case of letters in hex constants
in various dts files. The ones that are actually numbers probably
don't really matter, the but the node names are case sensitive
strings, and in some sense do matter.
I ask because some people I've spoken with internally seem to have
strong opinions about what case hex constants should be, and it'd be
nice to be able to have some guideline about this. Historically, I've
always seen DT hex values in lowercase.
Thanks,
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 6+ messages in thread
* hex number case in dts files.
2012-02-09 18:04 hex number case in dts files David Brown
@ 2012-02-09 18:20 ` Rob Herring
2012-02-10 0:19 ` David Gibson
0 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2012-02-09 18:20 UTC (permalink / raw)
To: linux-arm-kernel
On 02/09/2012 12:04 PM, David Brown wrote:
> I've noticed an inconsistency in the case of letters in hex constants
> in various dts files. The ones that are actually numbers probably
> don't really matter, the but the node names are case sensitive
> strings, and in some sense do matter.
>
> I ask because some people I've spoken with internally seem to have
> strong opinions about what case hex constants should be, and it'd be
> nice to be able to have some guideline about this. Historically, I've
> always seen DT hex values in lowercase.
>
Lower case should be used for dts files.
Rob
^ permalink raw reply [flat|nested] 6+ messages in thread
* hex number case in dts files.
2012-02-09 18:20 ` Rob Herring
@ 2012-02-10 0:19 ` David Gibson
2012-02-10 0:29 ` David Brown
0 siblings, 1 reply; 6+ messages in thread
From: David Gibson @ 2012-02-10 0:19 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 09, 2012 at 12:20:33PM -0600, Rob Herring wrote:
> On 02/09/2012 12:04 PM, David Brown wrote:
> > I've noticed an inconsistency in the case of letters in hex constants
> > in various dts files. The ones that are actually numbers probably
> > don't really matter, the but the node names are case sensitive
> > strings, and in some sense do matter.
> >
> > I ask because some people I've spoken with internally seem to have
> > strong opinions about what case hex constants should be, and it'd be
> > nice to be able to have some guideline about this. Historically, I've
> > always seen DT hex values in lowercase.
> >
>
> Lower case should be used for dts files.
Yes, the node names should always have the hex done in lower case. I
have plans to put more checks in for how reg is encoded into node
names, but just need to get time.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 6+ messages in thread
* hex number case in dts files.
2012-02-10 0:19 ` David Gibson
@ 2012-02-10 0:29 ` David Brown
2012-02-10 1:25 ` David Gibson
2012-02-10 17:25 ` Segher Boessenkool
0 siblings, 2 replies; 6+ messages in thread
From: David Brown @ 2012-02-10 0:29 UTC (permalink / raw)
To: linux-arm-kernel
On Fri, Feb 10, 2012 at 11:19:21AM +1100, David Gibson wrote:
> On Thu, Feb 09, 2012 at 12:20:33PM -0600, Rob Herring wrote:
> > On 02/09/2012 12:04 PM, David Brown wrote:
> > > I've noticed an inconsistency in the case of letters in hex constants
> > > in various dts files. The ones that are actually numbers probably
> > > don't really matter, the but the node names are case sensitive
> > > strings, and in some sense do matter.
> > >
> > > I ask because some people I've spoken with internally seem to have
> > > strong opinions about what case hex constants should be, and it'd be
> > > nice to be able to have some guideline about this. Historically, I've
> > > always seen DT hex values in lowercase.
> > >
> >
> > Lower case should be used for dts files.
>
> Yes, the node names should always have the hex done in lower case. I
> have plans to put more checks in for how reg is encoded into node
> names, but just need to get time.
What about number of digits? Should a register at 0x42 be
node at 00000042 or node at 42? Again, I'm seeing both.
Thanks,
David
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 6+ messages in thread
* hex number case in dts files.
2012-02-10 0:29 ` David Brown
@ 2012-02-10 1:25 ` David Gibson
2012-02-10 17:25 ` Segher Boessenkool
1 sibling, 0 replies; 6+ messages in thread
From: David Gibson @ 2012-02-10 1:25 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Feb 09, 2012 at 04:29:50PM -0800, David Brown wrote:
> On Fri, Feb 10, 2012 at 11:19:21AM +1100, David Gibson wrote:
> > On Thu, Feb 09, 2012 at 12:20:33PM -0600, Rob Herring wrote:
> > > On 02/09/2012 12:04 PM, David Brown wrote:
> > > > I've noticed an inconsistency in the case of letters in hex constants
> > > > in various dts files. The ones that are actually numbers probably
> > > > don't really matter, the but the node names are case sensitive
> > > > strings, and in some sense do matter.
> > > >
> > > > I ask because some people I've spoken with internally seem to have
> > > > strong opinions about what case hex constants should be, and it'd be
> > > > nice to be able to have some guideline about this. Historically, I've
> > > > always seen DT hex values in lowercase.
> > > >
> > >
> > > Lower case should be used for dts files.
> >
> > Yes, the node names should always have the hex done in lower case. I
> > have plans to put more checks in for how reg is encoded into node
> > names, but just need to get time.
>
> What about number of digits? Should a register at 0x42 be
> node at 00000042 or node at 42? Again, I'm seeing both.
node at 42
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
^ permalink raw reply [flat|nested] 6+ messages in thread
* hex number case in dts files.
2012-02-10 0:29 ` David Brown
2012-02-10 1:25 ` David Gibson
@ 2012-02-10 17:25 ` Segher Boessenkool
1 sibling, 0 replies; 6+ messages in thread
From: Segher Boessenkool @ 2012-02-10 17:25 UTC (permalink / raw)
To: linux-arm-kernel
> What about number of digits? Should a register at 0x42 be
> node at 00000042 or node at 42? Again, I'm seeing both.
It depends on the binding of the parent node. Most use no
leading zeroes except when representing 0 itself.
Segher
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-10 17:25 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-09 18:04 hex number case in dts files David Brown
2012-02-09 18:20 ` Rob Herring
2012-02-10 0:19 ` David Gibson
2012-02-10 0:29 ` David Brown
2012-02-10 1:25 ` David Gibson
2012-02-10 17:25 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).