[PATCH V3] MTD: atmel_nand: Update driver to support Programmable HW ECC controller

[PATCH V3] MTD: atmel_nand: Update driver to support Programmable HW ECC controller

[Artem Bityutskiy]

On Mon, 2012-02-06 at 09:32 +0800, Hong Xu wrote:
> +static int16_t *pmecc_get_index_of(struct atmel_nand_host *host)
> +{
> +       int16_t *p = (int16_t *)host->rom_base;

I did not really get into details, but you annotate rom_base with
__iomem, and then you have to cast it to int16_t in several - this does
not look very nice.

Could you please CC the arm list? There are much more people who can
give this code a review.

-- 
Best Regards,
Artem Bityutskiy
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: This is a digitally signed message part
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120211/275f8346/attachment.sig>

[PATCH V3] MTD: atmel_nand: Update driver to support Programmable HW ECC controller

[Xu, Hong]

Hi Artem,
> -----Original Message-----
> From: Artem Bityutskiy [mailto:dedekind1 at gmail.com]
> Sent: Saturday, February 11, 2012 7:28 PM
> To: Xu, Hong; linux-arm-kernel
> Cc: linux-mtd at lists.infradead.org; ivan.djelic at parrot.com;
> dwmw2 at infradead.org
> Subject: Re: [PATCH V3] MTD: atmel_nand: Update driver to support
Programmable
> HW ECC controller
> 
> On Mon, 2012-02-06 at 09:32 +0800, Hong Xu wrote:
> > +static int16_t *pmecc_get_index_of(struct atmel_nand_host *host)
> > +{
> > +       int16_t *p = (int16_t *)host->rom_base;
> 
> I did not really get into details, but you annotate rom_base with
> __iomem, and then you have to cast it to int16_t in several - this
does
> not look very nice.
> 
OK, this line shall be removed actually, thanks.
The logic here is, we want to use one lookup table which sits in ROM.
ROM region is mapped into kernel space by ioremap and the VA is saved in
rom_base. The function pmecc_get_index_of and pmecc_get_alpha_to are
used to return the correct ROM offset according to SoC and PMECC
configurations.
The lookup table is of type int16.

> Could you please CC the arm list? There are much more people who can
> give this code a review.
> 

OK, I'll resend the patch and CC the arm list.

Thanks and Br,
Eric
> --
> Best Regards,
> Artem Bityutskiy

[PATCH V3] MTD: atmel_nand: Update driver to support Programmable HW ECC controller

[Jean-Christophe PLAGNIOL-VILLARD]

On 13:28 Sat 11 Feb     , Artem Bityutskiy wrote:
> On Mon, 2012-02-06 at 09:32 +0800, Hong Xu wrote:
> > +static int16_t *pmecc_get_index_of(struct atmel_nand_host *host)
> > +{
> > +       int16_t *p = (int16_t *)host->rom_base;
this need to be passed via resource

Best Regards,
J.