From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: OMAP4: Move the barrier memboclk_steal() as part of reserve callback
Date: Tue, 14 Feb 2012 11:13:05 +0000 [thread overview]
Message-ID: <20120214111305.GF15338@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120210191926.GV1426@atomide.com>
On Fri, Feb 10, 2012 at 11:19:26AM -0800, Tony Lindgren wrote:
> * Santosh Shilimkar <santosh.shilimkar@ti.com> [120202 05:33]:
> > arm_memblock_steal() is not suppose to be used outside ->reserve callback.
> > OMAP barrier errata code was using it outside reserve callback and hence
> > it was broken.
> >
> > Move the allocation as part of ->reserve callback to fix the it.
>
> Please update this to mention again commit that changed things
> around for arm_memblock_steal() so it's clear why this is needed
> as a fix.
It's more the case that this whole errata fix was broken right from the
start, and the change to arm_memblock_steal() just enforced correct usage
of the APIs.
So, really the arm_memblock_steal() change has nothing to do with this.
next prev parent reply other threads:[~2012-02-14 11:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 14:03 [PATCH 0/2] ARM: OMAP: Couple of misc fixes for 3.3 Santosh Shilimkar
2012-02-02 14:03 ` [PATCH 1/2] ARM: OMAP: Get rid of reset for system timer Santosh Shilimkar
2012-02-02 18:40 ` Kevin Hilman
2012-02-03 7:15 ` Shilimkar, Santosh
2012-02-03 17:54 ` Kevin Hilman
2012-02-10 19:18 ` Tony Lindgren
2012-02-14 5:14 ` Rajendra Nayak
2012-02-14 7:15 ` Shilimkar, Santosh
2012-02-14 19:19 ` Tony Lindgren
2012-02-02 14:03 ` [PATCH 2/2] ARM: OMAP4: Move the barrier memboclk_steal() as part of reserve callback Santosh Shilimkar
2012-02-10 19:19 ` Tony Lindgren
2012-02-14 8:49 ` Santosh Shilimkar
2012-02-14 11:14 ` Russell King - ARM Linux
2012-02-14 11:29 ` Shilimkar, Santosh
2012-02-14 19:18 ` Tony Lindgren
2012-02-14 11:13 ` Russell King - ARM Linux [this message]
2012-02-06 9:33 ` [PATCH 0/2] ARM: OMAP: Couple of misc fixes for 3.3 Shilimkar, Santosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120214111305.GF15338@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).