linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: OMAP4: Move the barrier memboclk_steal() as part of reserve callback
Date: Tue, 14 Feb 2012 11:18:21 -0800	[thread overview]
Message-ID: <20120214191820.GP1426@atomide.com> (raw)
In-Reply-To: <CAMQu2gxRT3X7Q7bg0e-7=3HNKWjfQn7gLw9EQhY=g4U10yDMtg@mail.gmail.com>

* Shilimkar, Santosh <santosh.shilimkar@ti.com> [120214 02:58]:
> On Tue, Feb 14, 2012 at 4:44 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Tue, Feb 14, 2012 at 02:19:41PM +0530, Santosh Shilimkar wrote:
> >> >From 4d1ea22985adfe458275b9ae3e00edc6e41a267f Mon Sep 17 00:00:00 2001
> >> From: Santosh Shilimkar <santosh.shilimkar@ti.com>
> >> Date: Thu, 2 Feb 2012 15:59:51 +0530
> >> Subject: [PATCH 1/2] ARM: OMAP4: Move the barrier memboclk_steal() as
> >> part of reserve callback
> >>
> >> Commit 716a3dc{ARM: Add arm_memblock_steal() to allocate memory away
> >> from the kernel} introduced arm_memblock_steal() which lead to
> >> OMAP4_ERRATA_I688 to be broken and needed to be fixed.
> >
> > That is misleading. ?Please don't attribute blame for this breakage to
> > that patch, which has nothing to do with introducing the breakage. ?The
> > errata was broken right from the start.
> 
> That's right and I didn't mean that way.
> This was the same reason, first patch I just mentioned what was wrong
> in the code
> rather than mention of any commit.
> 
> Tony,
> Let me know if you want to add any commit history to the change since
> the issue was actually existing without 'arm_memblock_stea()' commit.
> I think, first change log was good enough from the fix point of view.

OK, makes sense. I'll apply it into fixes as is then.

Regards,

Tony

  reply	other threads:[~2012-02-14 19:18 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02 14:03 [PATCH 0/2] ARM: OMAP: Couple of misc fixes for 3.3 Santosh Shilimkar
2012-02-02 14:03 ` [PATCH 1/2] ARM: OMAP: Get rid of reset for system timer Santosh Shilimkar
2012-02-02 18:40   ` Kevin Hilman
2012-02-03  7:15     ` Shilimkar, Santosh
2012-02-03 17:54       ` Kevin Hilman
2012-02-10 19:18   ` Tony Lindgren
2012-02-14  5:14     ` Rajendra Nayak
2012-02-14  7:15       ` Shilimkar, Santosh
2012-02-14 19:19         ` Tony Lindgren
2012-02-02 14:03 ` [PATCH 2/2] ARM: OMAP4: Move the barrier memboclk_steal() as part of reserve callback Santosh Shilimkar
2012-02-10 19:19   ` Tony Lindgren
2012-02-14  8:49     ` Santosh Shilimkar
2012-02-14 11:14       ` Russell King - ARM Linux
2012-02-14 11:29         ` Shilimkar, Santosh
2012-02-14 19:18           ` Tony Lindgren [this message]
2012-02-14 11:13     ` Russell King - ARM Linux
2012-02-06  9:33 ` [PATCH 0/2] ARM: OMAP: Couple of misc fixes for 3.3 Shilimkar, Santosh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120214191820.GP1426@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).