From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: iop: add missing includes
Date: Wed, 15 Feb 2012 22:48:14 +0000 [thread overview]
Message-ID: <20120215224814.GG27825@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1329344682-29962-1-git-send-email-olof@lixom.net>
On Wed, Feb 15, 2012 at 02:24:42PM -0800, Olof Johansson wrote:
> Resolves two build breaks. One is a boatload of "unknown type name 'u32'"
> in iop3xx.h due to missing include of <linux/types.h>.
>
> The other is:
> arch/arm/plat-iop/restart.c: In function 'iop3xx_restart':
> arch/arm/plat-iop/restart.c:18:2: error: implicit declaration of function 'soft_restart' [-Werror=implicit-function-declaration]
Hmm, I think system.h has become quite a mess over the years.
I should've done something about that with the restart changes, and
created an asm/restart.h - the entire kernel doesn't need to know about
our soft restart stuff. Looks like there aren't that many users so at
least that kind of cleanup would be relatively simple.
next prev parent reply other threads:[~2012-02-15 22:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 22:24 [PATCH] ARM: iop: add missing includes Olof Johansson
2012-02-15 22:48 ` Russell King - ARM Linux [this message]
2012-03-19 19:40 ` Aaro Koskinen
2012-03-19 19:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215224814.GG27825@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).