From mboxrd@z Thu Jan 1 00:00:00 1970 From: shawn.guo@linaro.org (Shawn Guo) Date: Wed, 15 Feb 2012 16:15:59 -0800 Subject: [PATCH v2 5/7] ARM: imx: eliminate macro IRQ_GPIOx() In-Reply-To: References: <1329331668-30325-1-git-send-email-shawn.guo@linaro.org> <1329331668-30325-6-git-send-email-shawn.guo@linaro.org> Message-ID: <20120216001558.GC30946@r65073-Latitude-D630> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, Feb 15, 2012 at 09:29:27PM -0200, Fabio Estevam wrote: > On Wed, Feb 15, 2012 at 4:47 PM, Shawn Guo wrote: > > > +#define IMX_GPIOA(x) ?(GPIO_PORTA + x) > > +#define IMX_GPIOB(x) ?(GPIO_PORTB + x) > > +#define IMX_GPIOC(x) ?(GPIO_PORTC + x) > > +#define IMX_GPIOD(x) ?(GPIO_PORTD + x) > > +#define IMX_GPIOE(x) ?(GPIO_PORTE + x) > > +#define IMX_GPIOF(x) ?(GPIO_PORTF + x) > > Do we really need this new macros? > They are not brand new. They are here to help a plain translation from IRQ_GPIOx() to IMX_GPIOx(). > Why not use the standard IMX_GPIO_NR macro instead? It can be another patch, if you are interested. -- Regards, Shawn