linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: sam@ravnborg.org (Sam Ravnborg)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: amba: don't include <asm/sizes.h>
Date: Thu, 16 Feb 2012 18:25:51 +0100	[thread overview]
Message-ID: <20120216172551.GA31306@merkur.ravnborg.org> (raw)
In-Reply-To: <20120216160525.GA30558@mail.gnudd.com>

On Thu, Feb 16, 2012 at 05:05:25PM +0100, Alessandro Rubini wrote:
> The file uses no SZ_* symbol and some architectures miss sizes.h
> 
> Signed-off-by: Alessandro Rubini <rubini@gnudd.com>
> Acked-by: Giancarlo Asnaghi <giancarlo.asnaghi@st.com>
> ---
> 
> There a number of files including but not using it. This one
> in particular I need under x86 so the fix is trivial.
> 
> However, I remember different feelings about sizes.h . Should it die
> or should it proliferate to other archs using asm-generic/sizes.h ?

It would be good to have it included for all architectures.
It really has nothing arch specific in it so it ought to live in
include/linux:

    git mv include/asm-generic include/linux
    And a fix for the archs that will be broken by this.
    A small wrapper in arch/$ARCH/include/asm could do the trick


And speaking of this file I sometime have missed:
#define SZ_1K_BITS                       10
#define SZ_2K_BITS                       11

Or something similar.

	Sam

  reply	other threads:[~2012-02-16 17:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-16 16:05 [PATCH] ARM: amba: don't include <asm/sizes.h> Alessandro Rubini
2012-02-16 17:25 ` Sam Ravnborg [this message]
2012-02-16 18:20 ` Alessandro Rubini
2012-02-16 22:14 ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120216172551.GA31306@merkur.ravnborg.org \
    --to=sam@ravnborg.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).