From: mingo@elte.hu (Ingo Molnar)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] sched: generalize CONFIG_IRQ_TIME_ACCOUNTING for X86 and ARM
Date: Fri, 17 Feb 2012 12:22:58 +0100 [thread overview]
Message-ID: <20120217112258.GC14789@elte.hu> (raw)
In-Reply-To: <1328918525-7309-1-git-send-email-dmitry.antipov@linaro.org>
* Dmitry Antipov <dmitry.antipov@linaro.org> wrote:
> --- a/kernel/sched/core.c
> +++ b/kernel/sched/core.c
> @@ -757,18 +757,20 @@ static DEFINE_PER_CPU(u64, cpu_hardirq_time);
> static DEFINE_PER_CPU(u64, cpu_softirq_time);
>
> static DEFINE_PER_CPU(u64, irq_start_time);
> -static int sched_clock_irqtime;
>
> -void enable_sched_clock_irqtime(void)
> -{
> - sched_clock_irqtime = 1;
> -}
> +/* -1 if not initialized, 0 if disabled with "noirqtime" kernel option
> + * or after unstable clock was detected, 1 if enabled and active.
> + */
Please use the customary (multi-line) comment style:
/*
* Comment .....
* ...... goes here.
*/
specified in Documentation/CodingStyle.
> +int sched_clock_irqtime = -1;
should be turned into __read_mostly I guess.
Thanks,
Ingo
next prev parent reply other threads:[~2012-02-17 11:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-11 0:02 [PATCH] sched: generalize CONFIG_IRQ_TIME_ACCOUNTING for X86 and ARM Dmitry Antipov
2012-02-17 11:22 ` Ingo Molnar [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-02-28 6:29 Dmitry Antipov
2012-02-20 6:04 Dmitry Antipov
2012-02-27 10:12 ` Peter Zijlstra
2012-02-28 6:19 ` Dmitry Antipov
2012-02-09 17:25 Dmitry Antipov
2012-02-10 22:28 ` Venki Pallipadi
2012-02-08 23:58 Dmitry Antipov
2012-02-08 16:08 Dmitry Antipov
2012-02-08 22:50 ` Venki Pallipadi
2012-02-08 12:48 Dmitry Antipov
2012-02-08 13:18 ` Russell King - ARM Linux
2012-02-08 15:15 ` Dmitry Antipov
2012-02-08 15:24 ` Russell King - ARM Linux
2012-02-09 2:51 ` Yong Zhang
2012-02-09 2:48 ` Yong Zhang
2012-02-07 18:06 Dmitry Antipov
2012-02-07 22:56 ` Venki Pallipadi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120217112258.GC14789@elte.hu \
--to=mingo@elte.hu \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).