From: sameo@linux.intel.com (Samuel Ortiz)
To: linux-arm-kernel@lists.infradead.org
Subject: mc13xxx: add I2C support
Date: Mon, 20 Feb 2012 17:50:53 +0100 [thread overview]
Message-ID: <20120220165053.GA5387@sortiz-mobl> (raw)
In-Reply-To: <201201201855.35971.marc@cpdesign.com.au>
Hi Marc,
On Fri, Jan 20, 2012 at 06:55:35PM +1100, Marc Reilly wrote:
> Hi,
>
> Thankyou all for your feedback and comments. I'll use them for a V2 but
> Samuel, I'd like to know if you'd like me to base them on a specific branch
> before I do.
Please rebase it against my for-next branch.
> Shawn, thanks for testing!
>
> On Thursday, January 19, 2012 10:29:41 PM Mark Brown wrote:
> > On Thu, Jan 19, 2012 at 12:12:31PM +0100, Arnaud Patard wrote:
> > > I've never looked at regmap deeply but can't it be done with regmap or is
> > > it just a bad idea ?
> >
> > Glancing quickly at the existing code it should map on reasonably well,
> > though a new format definition may be required for the 25 bit shift that
> > would be trivial.
>
> I'm sadly unfamiliar with regmap, is it a far superior solution? does it need
> to used now? (ie. I'm relucant to totally rework this now. Please convince me
> I need to if required.)
I think Mark exposed the advantages of using regmap. It's not a mandatory API
usage at that point, but since we still have about 4 weeks before the next
merge window opens, and since the changes wouldn't be a huge piece of work,
I'd recommend switching to it now.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
prev parent reply other threads:[~2012-02-20 16:50 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-19 1:01 mc13xxx: add I2C support Marc Reilly
2012-01-19 1:01 ` [PATCH 1/3] mc13xxx-core: Prepare for separate spi and i2c backends Marc Reilly
2012-01-19 7:35 ` Shawn Guo
2012-01-19 7:51 ` Uwe Kleine-König
2012-01-19 1:01 ` [PATCH 2/3] mfd: mc13xxx-core: Move spi specific code into separate module Marc Reilly
2012-01-19 8:08 ` Uwe Kleine-König
2012-01-19 12:54 ` Grant Likely
2012-01-19 1:01 ` [PATCH 3/3] mfd: mc13xxx-core: Add i2c driver Marc Reilly
2012-01-19 7:22 ` mc13xxx: add I2C support Shawn Guo
2012-01-19 11:12 ` Arnaud Patard (Rtp)
2012-01-19 11:29 ` Mark Brown
[not found] ` <201201201855.35971.marc@cpdesign.com.au>
2012-01-20 10:36 ` Arnaud Patard (Rtp)
2012-01-20 12:08 ` Mark Brown
2012-02-20 16:50 ` Samuel Ortiz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220165053.GA5387@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).