From: sameo@linux.intel.com (Samuel Ortiz)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/3] MFD: twl6040: Conversion to i2c driver
Date: Mon, 20 Feb 2012 20:47:36 +0100 [thread overview]
Message-ID: <20120220194736.GN5387@sortiz-mobl> (raw)
In-Reply-To: <1328868018-24668-1-git-send-email-peter.ujfalusi@ti.com>
Hi Peter,
On Fri, Feb 10, 2012 at 12:00:15PM +0200, Peter Ujfalusi wrote:
> Hello,
>
> Changes since v2:
> - soc/codec/Kconfig: make twl6040 depend on I2C
> - Regulator related patches has been removed (to be sent as separate series)
I applied all 3 patches. Patch #2 did not apply cleanly, due to the fact that
several struct twl4030_codec_data omap4panda.c references are not upstream
yet. This is my .rej:
--- arch/arm/mach-omap2/board-omap4panda.c
+++ arch/arm/mach-omap2/board-omap4panda.c
@@ -278,7 +279,7 @@
return 0;
}
-static struct twl4030_codec_data twl6040_codec = {
+static struct twl6040_codec_data twl6040_codec = {
/* single-step ramp for headset and handsfree */
.hs_left_step = 0x0f,
.hs_right_step = 0x0f,
@@ -286,17 +287,14 @@
.hf_right_step = 0x1d,
};
-static struct twl4030_audio_data twl6040_audio = {
+static struct twl6040_platform_data twl6040_data = {
.codec = &twl6040_codec,
.audpwron_gpio = 127,
- .naudint_irq = OMAP44XX_IRQ_SYS_2N,
.irq_base = TWL6040_CODEC_IRQ_BASE,
};
/* Panda board uses the common PMIC configuration */
-static struct twl4030_platform_data omap4_panda_twldata = {
- .audio = &twl6040_audio,
-};
+static struct twl4030_platform_data omap4_panda_twldata;
I'm not sure hwo we could handle that properly. Either by letting Tony
carrying this patchset, or by sending me the panda patch that adds those
structures. As you prefer.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
next prev parent reply other threads:[~2012-02-20 19:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-10 10:00 [PATCH v3 0/3] MFD: twl6040: Conversion to i2c driver Peter Ujfalusi
2012-02-10 10:00 ` [PATCH v3 1/3] MFD: twl-core: Detach twl6040 from the pmic mfd driver Peter Ujfalusi
2012-02-10 10:00 ` [PATCH v3 2/3] MFD: twl6040: Convert to i2c driver, and separate it from twl core Peter Ujfalusi
2012-02-21 18:43 ` Tony Lindgren
2012-02-10 10:00 ` [PATCH v3 3/3] ASoC: twl6040: Remove dependency on twl4030 from Kconfig Peter Ujfalusi
2012-02-10 11:10 ` Mark Brown
2012-02-17 11:47 ` [PATCH v3 0/3] MFD: twl6040: Conversion to i2c driver Peter Ujfalusi
2012-02-20 19:47 ` Samuel Ortiz [this message]
2012-02-21 10:33 ` Peter Ujfalusi
2012-02-21 11:05 ` Samuel Ortiz
2012-02-21 17:52 ` Liam Girdwood
2012-02-21 18:44 ` Tony Lindgren
2012-02-22 7:34 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120220194736.GN5387@sortiz-mobl \
--to=sameo@linux.intel.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).