From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH - linux-next] ARM: ptrace: Fix audit caused compile error
Date: Tue, 21 Feb 2012 13:30:44 +0000	[thread overview]
Message-ID: <20120221133044.GN22562@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120221131616.GI19696@mudshark.cambridge.arm.com>
On Tue, Feb 21, 2012 at 01:16:17PM +0000, Will Deacon wrote:
> On Tue, Feb 21, 2012 at 12:04:15PM +0000, Peter Ujfalusi wrote:
> > While trying to compile the kernel for ARM (omap2plus_defconfig) the kernel
> > build fails with:
> > 
> > arch/arm/kernel/ptrace.c: In function ?syscall_trace?:
> > arch/arm/kernel/ptrace.c:920:3: error: implicit declaration of function ?audit_syscall_exit?
> > arch/arm/kernel/ptrace.c:922:3: error: implicit declaration of function ?audit_syscall_entry?
> > arch/arm/kernel/ptrace.c:922:23: error: ?AUDIT_ARCH_ARMEB? undeclared (first use in this function)
> > arch/arm/kernel/ptrace.c:922:23: note: each undeclared identifier is reported only once for each function it appears in
> > make[1]: *** [arch/arm/kernel/ptrace.o] Error 1
> > 
> > The issue created by commit:
> > 29ef73b7 Kernel: Audit Support For The ARM Platform
> > 
> > We need to include the linux/audit.h header to the arch/arm/kernel/ptrace.c
> > file to be able to compile the kernel.
> 
> This was already reported and I think Russell was going to revert the
> offending commit, since it needed some rework to handle little-endian
> configurations.
> 
> I can't see the revert in any of the trees I'm tracking though...
I never pushed that out because I thought someone was going to fix it.
Were any patches produced to fix it?  I can't see anything in the patch
system and I couldn't see anything on the list.
It seems the previous thread about it just died.  Oh well, I guess a
revert is what's required after all.
next prev parent reply	other threads:[~2012-02-21 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-21 12:04 [PATCH - linux-next] ARM: ptrace: Fix audit caused compile error Peter Ujfalusi
2012-02-21 13:16 ` Will Deacon
2012-02-21 13:30   ` Russell King - ARM Linux [this message]
2012-02-21 13:35     ` Eric Paris
2012-02-21 13:49       ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox
  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):
  git send-email \
    --in-reply-to=20120221133044.GN22562@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY
  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
  Be sure your reply has a Subject: header at the top and a blank line
  before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).