From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv5 02/14] arm: omap: voltage: renamed vp_vddmin and vp_vddmax fields
Date: Tue, 21 Feb 2012 14:53:22 +0000 [thread overview]
Message-ID: <20120221145322.GD22675@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAOMWX4cviUjAJ2eCB5LjUBmOpEWU5HP9-miPtZY1TwBGYyOPdA@mail.gmail.com>
On Tue, Feb 21, 2012 at 08:40:22AM -0600, Menon, Nishanth wrote:
> On Tue, Feb 21, 2012 at 08:04, Tero Kristo <t-kristo@ti.com> wrote:
> > These are now called vddmin and vddmax, as these fields will be used
> > globally for selecting voltage ranges for a pmic channel, and not
> > only for voltage processor.
>
> NAK. I think we need to setup voltage for SoC limits as well. the
> programmed voltage to the VP register should be:
> VP->vlimito->min = MAX(soc->vdd_min, pmic->vdd_min)
> VP->vlimito->max = MIN(soc->vdd_max, pmic->vdd_max)
>
> else you could be running the SoC beyond design voltage potentially
> damaging the device.
And if you're doing that kind of thing, you must also check that
the resulting min and max are sane. In other words, the minimum is
less than the maximum.
Sure, it's something that should never happen (because it would be a
design error) but if it did happen...
next prev parent reply other threads:[~2012-02-21 14:53 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 14:04 [PATCHv5 00/14] arm: omap3: auto-ret / auto-off support Tero Kristo
2012-02-21 14:04 ` [PATCHv5 01/14] arm: OMAP3+: PM: VP: use uV for max and min voltage limits Tero Kristo
2012-02-21 14:04 ` [PATCHv5 02/14] arm: omap: voltage: renamed vp_vddmin and vp_vddmax fields Tero Kristo
2012-02-21 14:40 ` Menon, Nishanth
2012-02-21 14:53 ` Russell King - ARM Linux [this message]
2012-02-21 15:32 ` Tero Kristo
2012-02-21 15:38 ` Nishanth Menon
2012-02-21 14:04 ` [PATCHv5 03/14] arm: omap3+: voltage: parameter segregation Tero Kristo
2012-02-23 1:37 ` Menon, Nishanth
2012-02-23 9:08 ` Tero Kristo
2012-02-23 15:05 ` Menon, Nishanth
2012-02-21 14:04 ` [PATCHv5 04/14] arm: omap: voltage: add definition for pmic startup / shutdown times Tero Kristo
2012-02-21 14:04 ` [PATCHv5 05/14] arm: omap4: add " Tero Kristo
2012-02-21 14:04 ` [PATCHv5 06/14] arm: omap: add support for oscillator setup Tero Kristo
2012-02-21 14:44 ` Menon, Nishanth
2012-02-21 14:04 ` [PATCHv5 07/14] arm: omap3+: vp: use new vp_params for calculating vddmin and vddmax Tero Kristo
2012-02-21 14:04 ` [PATCHv5 08/14] arm: omap3+: voltage: use oscillator data to calculate setup times Tero Kristo
2012-02-21 14:04 ` [PATCHv5 09/14] arm: omap4: use pmic params for calculating pmic " Tero Kristo
2012-02-21 14:04 ` [PATCHv5 10/14] TEMP: arm: OMAP3: beagle rev-c4: enable OPP6 Tero Kristo
2012-02-21 14:04 ` [PATCHv5 11/14] arm: omap: beagle: set oscillator startup time to 10ms for rev c4 Tero Kristo
2012-02-21 14:04 ` [PATCHv5 12/14] arm: omap3: vc: auto_ret / auto_off support Tero Kristo
2012-02-21 14:04 ` [PATCHv5 13/14] arm: omap3: voltage: fix channel configuration Tero Kristo
2012-02-21 14:04 ` [PATCHv5 14/14] arm: omap: pm: wait for domain wakeup if changing state of idle domain Tero Kristo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120221145322.GD22675@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).