[PATCH 0/2] Two trivial omap/serial patches

[PATCH 0/2] Two trivial omap/serial patches

[NeilBrown]

Just a couple of small clean-ups following the recent major changes.

Thanks,
NeilBrown

---

NeilBrown (2):
      ARM: OMAP2: remove some orphan function declarations.
      ARM: OMAP2+: UART: remove unused fields in omap_uart_state.


 arch/arm/mach-omap2/pm.h                 |    1 -
 arch/arm/mach-omap2/serial.c             |    4 ----
 arch/arm/plat-omap/include/plat/serial.h |    1 -
 3 files changed, 0 insertions(+), 6 deletions(-)

-- 
Signature

[PATCH 1/2] ARM: OMAP2+: UART: remove unused fields in omap_uart_state.

[NeilBrown]

commit 2fd149645eb46d261 removed the last usage of 'can_sleep' but
did not remove the field.
commit  8612bd22f3036974 removed the last non-trivial use of 'pdev'.

So remove these fields and the one trivial use.

Acked-by: Govindraj.R <govindraj.raja@ti.com>
Signed-off-by: NeilBrown <neilb@suse.de>
---

 arch/arm/mach-omap2/serial.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-omap2/serial.c b/arch/arm/mach-omap2/serial.c
index f590afc..0cdd359 100644
--- a/arch/arm/mach-omap2/serial.c
+++ b/arch/arm/mach-omap2/serial.c
@@ -54,11 +54,9 @@
 
 struct omap_uart_state {
 	int num;
-	int can_sleep;
 
 	struct list_head node;
 	struct omap_hwmod *oh;
-	struct platform_device *pdev;
 };
 
 static LIST_HEAD(uart_list);
@@ -381,8 +379,6 @@ void __init omap_serial_init_port(struct omap_board_data *bdata,
 
 	oh->mux = omap_hwmod_mux_init(bdata->pads, bdata->pads_cnt);
 
-	uart->pdev = pdev;
-
 	oh->dev_attr = uart;
 
 	if (((cpu_is_omap34xx() || cpu_is_omap44xx()) && bdata->pads)

[PATCH 1/2] ARM: OMAP2+: UART: remove unused fields in omap_uart_state.

[Sergei Shtylyov]

Hello.

On 19-02-2012 6:29, NeilBrown wrote:

> commit 2fd149645eb46d261 removed the last usage of 'can_sleep' but
> did not remove the field.
> commit  8612bd22f3036974 removed the last non-trivial use of 'pdev'.

    Please also specify the summaries of the above commits with them.

> So remove these fields and the one trivial use.

    This seems like the material for 2 patches.

> Acked-by: Govindraj.R <govindraj.raja@ti.com>
> Signed-off-by: NeilBrown <neilb@suse.de>

WBR, Sergei

[PATCH 2/2] ARM: OMAP2: remove some orphan function declarations.

[NeilBrown]

commit 2fd149645eb removed omap_uart_can_sleep and omap3_can_sleep,
but not their declarations.  So remove those now.

Signed-off-by: NeilBrown <neilb@suse.de>
---

 arch/arm/mach-omap2/pm.h                 |    1 -
 arch/arm/plat-omap/include/plat/serial.h |    1 -
 2 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
index b737b11..6cd954d 100644
--- a/arch/arm/mach-omap2/pm.h
+++ b/arch/arm/mach-omap2/pm.h
@@ -18,7 +18,6 @@
 extern void *omap3_secure_ram_storage;
 extern void omap3_pm_off_mode_enable(int);
 extern void omap_sram_idle(void);
-extern int omap3_can_sleep(void);
 extern int omap_set_pwrdm_state(struct powerdomain *pwrdm, u32 state);
 extern int omap3_idle_init(void);
 extern int omap4_idle_init(void);
diff --git a/arch/arm/plat-omap/include/plat/serial.h b/arch/arm/plat-omap/include/plat/serial.h
index 198d1e6..b073e5f 100644
--- a/arch/arm/plat-omap/include/plat/serial.h
+++ b/arch/arm/plat-omap/include/plat/serial.h
@@ -110,7 +110,6 @@ struct omap_board_data;
 struct omap_uart_port_info;
 
 extern void omap_serial_init(void);
-extern int omap_uart_can_sleep(void);
 extern void omap_serial_board_init(struct omap_uart_port_info *platform_data);
 extern void omap_serial_init_port(struct omap_board_data *bdata,
 		struct omap_uart_port_info *platform_data);

[PATCH 2/2] ARM: OMAP2: remove some orphan function declarations.

[Shubhrajyoti]

On Sunday 19 February 2012 07:59 AM, NeilBrown wrote:
> commit 2fd149645eb removed omap_uart_can_sleep and omap3_can_sleep,
> but not their declarations.  So remove those now.
>
a small description with the commit id would have been good.


Looks good to me.
Reviewed-by: Shubhrajyoti D <shubhrajyoti@ti.com>

thanks.
> Signed-off-by: NeilBrown <neilb@suse.de>
> ---
>
>  arch/arm/mach-omap2/pm.h                 |    1 -
>  arch/arm/plat-omap/include/plat/serial.h |    1 -
>  2 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.h b/arch/arm/mach-omap2/pm.h
> index b737b11..6cd954d 100644
> --- a/arch/arm/mach-omap2/pm.h
> +++ b/arch/arm/mach-omap2/pm.h
> @@ -18,7 +18,6 @@
>  extern void *omap3_secure_ram_storage;
>  extern void omap3_pm_off_mode_enable(int);
>  extern void omap_sram_idle(void);
> -extern int omap3_can_sleep(void);
>  extern int omap_set_pwrdm_state(struct powerdomain *pwrdm, u32 state);
>  extern int omap3_idle_init(void);
>  extern int omap4_idle_init(void);
> diff --git a/arch/arm/plat-omap/include/plat/serial.h b/arch/arm/plat-omap/include/plat/serial.h
> index 198d1e6..b073e5f 100644
> --- a/arch/arm/plat-omap/include/plat/serial.h
> +++ b/arch/arm/plat-omap/include/plat/serial.h
> @@ -110,7 +110,6 @@ struct omap_board_data;
>  struct omap_uart_port_info;
>  
>  extern void omap_serial_init(void);
> -extern int omap_uart_can_sleep(void);
>  extern void omap_serial_board_init(struct omap_uart_port_info *platform_data);
>  extern void omap_serial_init_port(struct omap_board_data *bdata,
>  		struct omap_uart_port_info *platform_data);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] ARM: OMAP2: remove some orphan function declarations.

[Sergei Shtylyov]

Hello.

On 19-02-2012 6:29, NeilBrown wrote:

> commit 2fd149645eb

    Please also specify that commit's summary in parens.

> removed omap_uart_can_sleep and omap3_can_sleep,
> but not their declarations.  So remove those now.

> Signed-off-by: NeilBrown <neilb@suse.de>

WBR, Sergei

[PATCH 0/2] Two trivial omap/serial patches

[Kevin Hilman]

NeilBrown <neilb@suse.de> writes:

> Just a couple of small clean-ups following the recent major changes.

Thanks Neil.

I'll queue these as cleanups for v3.4 since I dont' think they're v3.3
material at this point of the cycle.

I'll also update the changelogs to follow the practice of adding the
shortlog in parens after the commit ID.

Kevin


>
> Thanks,
> NeilBrown
>
> ---
>
> NeilBrown (2):
>       ARM: OMAP2: remove some orphan function declarations.
>       ARM: OMAP2+: UART: remove unused fields in omap_uart_state.
>
>
>  arch/arm/mach-omap2/pm.h                 |    1 -
>  arch/arm/mach-omap2/serial.c             |    4 ----
>  arch/arm/plat-omap/include/plat/serial.h |    1 -
>  3 files changed, 0 insertions(+), 6 deletions(-)

[PATCH 0/2] Two trivial omap/serial patches

[NeilBrown]

On Tue, 21 Feb 2012 11:10:30 -0800 Kevin Hilman <khilman@ti.com> wrote:

> NeilBrown <neilb@suse.de> writes:
> 
> > Just a couple of small clean-ups following the recent major changes.
> 
> Thanks Neil.
> 
> I'll queue these as cleanups for v3.4 since I dont' think they're v3.3
> material at this point of the cycle.

Thanks,

> 
> I'll also update the changelogs to follow the practice of adding the
> shortlog in parens after the commit ID.

I'll try to remember that for next time.

Thanks,
NeilBrown
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 828 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120222/c548e47e/attachment.sig>