From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: S3C24XX: Move the DMA base code to mach-s3c24xx
Date: Wed, 22 Feb 2012 17:21:41 +0000 [thread overview]
Message-ID: <201202221721.41262.arnd@arndb.de> (raw)
In-Reply-To: <201202212226.57559.heiko@sntech.de>
On Tuesday 21 February 2012, Heiko St?bner wrote:
> Signed-off-by: Heiko Stuebner <heiko@sntech.de>
> ---
> arch/arm/mach-s3c24xx/Kconfig | 18 +
> arch/arm/mach-s3c24xx/Makefile | 1 +
> arch/arm/mach-s3c24xx/dma.c | 1469 ++++++++++++++++++++++++++++++++++++++++
> arch/arm/plat-s3c24xx/Kconfig | 16 -
> arch/arm/plat-s3c24xx/Makefile | 1 -
> arch/arm/plat-s3c24xx/dma.c | 1469 ----------------------------------------
> 6 files changed, 1488 insertions(+), 1486 deletions(-)
> create mode 100644 arch/arm/mach-s3c24xx/dma.c
> delete mode 100644 arch/arm/plat-s3c24xx/dma.c
>
Wouldn't it be more appropriate to move this driver to
drivers/dma/s3c24xx-dma.c instead?
Even if it doesn't (yet) use the dmaengine API, I think it's
valuable to keep drivers with the same purpose together. We have
had similar discussions in other subsystems and ended up moving
the drivers into one directory first, followed by a conversion
to a common API (if someone could be motivated to do that work).
Arnd
next prev parent reply other threads:[~2012-02-22 17:21 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-21 21:21 [PATCH 0/2] Move some stuff into the new mach-s3c24xx Heiko Stübner
2012-02-21 21:26 ` [PATCH 1/2] ARM: S3C24XX: Move s3c2443-clock.c to mach-s3c24xx Heiko Stübner
2012-02-22 17:18 ` Arnd Bergmann
2012-02-22 17:28 ` Heiko Stübner
2012-02-22 17:42 ` Kukjin Kim
2012-02-22 17:51 ` Jassi Brar
2012-02-23 14:35 ` [PATCH v2] " Heiko Stübner
2012-03-01 4:32 ` Kukjin Kim
2012-02-21 21:26 ` [PATCH 2/2] ARM: S3C24XX: Move the DMA base code " Heiko Stübner
2012-02-22 17:21 ` Arnd Bergmann [this message]
2012-02-22 17:38 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202221721.41262.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox