From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/
Date: Wed, 22 Feb 2012 19:35:27 +0000 [thread overview]
Message-ID: <20120222193526.GC7041@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CABb+yY0Zy3Xx4OZTobo2y-J4NXokGCV47PdPyKs+aOnqtng7pQ@mail.gmail.com>
On Wed, Feb 22, 2012 at 10:50:29PM +0530, Jassi Brar wrote:
> > * Based on:
> > * ? ? ? arch/arm/common/pl330.c, arch/arm/include/asm/hardware/pl330.h
> > * ? ? ? Copyright (C) 2010 Samsung Electronics Co Ltd.
> >
> Doesn't make any sense because arch/arm/common/pl330.c
> and arch/arm/include/asm/hardware/pl330.h wouldn't exist anymore,
Rubbish. It does make sense, because it's saying where the changes
came from. That's done quite often when moving code around.
You could say that moving code from file A to file B and commenting
that it came from file A makes no sense because the code is no longer
in file A. Well, that's definitely the case, but that doesn't mean
you don't credit where it came from in the first place.
I think you're making a mountain out of this mole hill. There isn't
a problem here. The above comments saying what happened are fine.
next prev parent reply other threads:[~2012-02-22 19:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1329341243-14314-1-git-send-email-kgene.kim@samsung.com>
2012-02-21 11:25 ` [PATCH v3] DMA: PL330: Merge PL330 driver into drivers/dma/ Kukjin Kim
2012-02-21 16:21 ` Jassi Brar
2012-02-22 0:22 ` Kukjin Kim
2012-02-22 1:40 ` Jassi Brar
2012-02-22 2:11 ` Kukjin Kim
2012-02-22 2:31 ` Jassi Brar
2012-02-22 10:27 ` Vinod Koul
2012-02-22 11:12 ` Jassi Brar
2012-02-22 19:33 ` Russell King - ARM Linux
2012-02-22 16:51 ` Kukjin Kim
2012-02-22 17:20 ` Jassi Brar
2012-02-22 17:29 ` Kukjin Kim
2012-02-22 17:40 ` Jassi Brar
2012-02-22 19:35 ` Russell King - ARM Linux [this message]
2012-02-22 22:43 ` Jassi Brar
2012-02-23 0:46 ` Kukjin Kim
2012-02-22 19:31 ` Russell King - ARM Linux
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222193526.GC7041@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).