From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 1/6] ARM: ftrace: remove useless memory checks
Date: Wed, 22 Feb 2012 21:28:21 +0000 [thread overview]
Message-ID: <20120222212821.GE7041@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <20120222141317.GB9031@debian>
On Wed, Feb 22, 2012 at 07:43:17PM +0530, Rabin Vincent wrote:
> On Mon, Feb 20, 2012 at 04:16:01PM +0000, Russell King - ARM Linux wrote:
> > On Sat, Jan 28, 2012 at 07:05:20PM +0530, Rabin Vincent wrote:
> > > diff --git a/arch/arm/kernel/ftrace.c b/arch/arm/kernel/ftrace.c
> > > index c0062ad..e9488ad 100644
> > > --- a/arch/arm/kernel/ftrace.c
> > > +++ b/arch/arm/kernel/ftrace.c
> > > @@ -125,11 +125,13 @@ static int ftrace_modify_code(unsigned long pc, unsigned long old,
> > > {
> > > unsigned long replaced;
> > >
> > > - if (probe_kernel_read(&replaced, (void *)pc, MCOUNT_INSN_SIZE))
> > > - return -EFAULT;
> > > + if (old) {
> >
> > So, we're using the instruction value '0' to mean that we don't want to
> > check? Wouldn'it it be better to pass a flag in to indicate this instead
> > of creating a magic value?
>
> OK. I think you applied this patch as-is anyway, so here is a follow-on
> patch:
I'd still much prefer it to be part of the original patch. I can replace
the patch I've merged or augment it with another patch - whichever way
you prefer.
next prev parent reply other threads:[~2012-02-22 21:28 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-28 13:35 [PATCHv2 0/6] ARM: jump label support Rabin Vincent
2012-01-28 13:35 ` [PATCHv2 1/6] ARM: ftrace: remove useless memory checks Rabin Vincent
2012-02-20 16:16 ` Russell King - ARM Linux
2012-02-22 14:13 ` Rabin Vincent
2012-02-22 21:28 ` Russell King - ARM Linux [this message]
2012-02-24 16:48 ` Rabin Vincent
2012-02-27 11:21 ` Russell King - ARM Linux
2012-01-28 13:35 ` [PATCHv2 2/6] ARM: ftrace: use canonical Thumb-2 wide instruction format Rabin Vincent
2012-01-30 16:54 ` Dave Martin
2012-01-28 13:35 ` [PATCHv2 3/6] ARM: extract out insn generation code from ftrace Rabin Vincent
2012-01-28 13:35 ` [PATCHv2 4/6] ARM: extract out code patch function from kprobes Rabin Vincent
2012-01-30 17:00 ` Dave Martin
2012-02-07 16:07 ` [PATCHv3] " Rabin Vincent
2012-01-31 18:32 ` [PATCHv2 4/6] " Tixy
2012-01-28 13:35 ` [PATCHv2 5/6] jump label: detect %c support for ARM Rabin Vincent
2012-02-07 16:18 ` Rabin Vincent
2012-02-07 18:04 ` Jason Baron
2012-02-20 17:21 ` Russell King - ARM Linux
2012-02-22 13:32 ` Rabin Vincent
2012-01-28 13:35 ` [PATCHv2 6/6] ARM: add jump label support Rabin Vincent
2012-02-15 17:00 ` [PATCHv3] " Rabin Vincent
2012-02-29 15:24 ` Rabin Vincent
2012-02-29 15:47 ` Jason Baron
2012-01-31 8:23 ` [PATCHv2 0/6] ARM: " Jon Medhurst (Tixy)
2012-01-31 11:11 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120222212821.GE7041@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).