linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: u.kleine-koenig@pengutronix.de (Uwe Kleine-König)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for platform_cpu_die()
Date: Thu, 23 Feb 2012 08:45:04 +0100	[thread overview]
Message-ID: <20120223074504.GZ14173@pengutronix.de> (raw)
In-Reply-To: <1329980310-9007-3-git-send-email-santosh.shilimkar@ti.com>

Hello,

On Thu, Feb 23, 2012 at 12:28:30PM +0530, Santosh Shilimkar wrote:
> WARNING: vmlinux.o(.text+0x226d0):
> Section mismatch in reference from the function
> platform_cpu_die() to the function .cpuinit.text:omap4_hotplug_cpu()
> The function platform_cpu_die() references
> the function __cpuinit omap4_hotplug_cpu().
> This is often because platform_cpu_die lacks a __cpuinit
> annotation or the annotation of omap4_hotplug_cpu is wrong.
> 
> Thanks to Russell King for suggesting __ref annotation trick
> just like it's parent function for this warning becasue __cupinit
s/it's/its/; s/becasue/because/; s/cup/cpu/

Having said that I think the grammar is broken, too. Maybe:

	Thanks to Russell King for suggesting to use __ref instead of
	the initial (and wrong) approach to use __cpuinit.

(But note I'm not a native speaker, too)

Uwe

> usage was definitely wrong to fix this warning..

-- 
Pengutronix e.K.                           | Uwe Kleine-K?nig            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

  reply	other threads:[~2012-02-23  7:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-23  6:58 [PATCH 0/2] OMAP: Section mismatch warning fixes Santosh Shilimkar
2012-02-23  6:58 ` [PATCH 1/2] ARM: OMAP: fix section mismatch warning for omap4_hotplug_cpu() Santosh Shilimkar
2012-02-23  6:58 ` [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for platform_cpu_die() Santosh Shilimkar
2012-02-23  7:45   ` Uwe Kleine-König [this message]
2012-02-23  8:40     ` Shilimkar, Santosh
2012-02-28 22:34       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120223074504.GZ14173@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).