From: linux@arm.linux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm/io.h: add macros to read/write big/little endian register
Date: Thu, 23 Feb 2012 11:38:01 +0000 [thread overview]
Message-ID: <20120223113801.GV22562@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <4F462444.8060406@st.com>
On Thu, Feb 23, 2012 at 05:04:28PM +0530, Pratyush Anand wrote:
> On 2/23/2012 4:49 PM, Russell King - ARM Linux wrote:
>> On Thu, Feb 23, 2012 at 04:23:11PM +0530, Viresh Kumar wrote:
>>> On 2/23/2012 3:23 PM, Russell King - ARM Linux wrote:
>>>> 1. Using the PCI/ISA IO macros for non-PCI/ISA IO purposes is silly
>>>
>>> We mistakenly placed it outside #ifdef __io, #endif
>>> Sorry, i am still missing your point.
>>
>> inb() et.al. are for PCI/ISA IO, not for general platform MMIO.
>>
>
> Ok.. So, will it be fine if we keep it outside #ifdef __io and do not
> use __io macro in their implementation?
No, I refuse to add another set of accessors to ARMs io.h. They're private
to PPC - it even says so in their header file. They should not have leaked
out of PPC.
The fact that 73 drivers in the kernel source use their accessors is their
problem to solve.
next prev parent reply other threads:[~2012-02-23 11:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 9:17 [PATCH] arm/io.h: add macros to read/write big/little endian register Viresh Kumar
2012-02-23 9:53 ` Russell King - ARM Linux
2012-02-23 10:53 ` Viresh Kumar
2012-02-23 11:19 ` Russell King - ARM Linux
2012-02-23 11:30 ` Russell King - ARM Linux
2012-02-23 11:34 ` Pratyush Anand
2012-02-23 11:38 ` Russell King - ARM Linux [this message]
2012-02-23 12:33 ` Arnd Bergmann
2012-02-23 12:50 ` Russell King - ARM Linux
2012-02-23 13:35 ` Arnd Bergmann
2012-02-23 14:14 ` Russell King - ARM Linux
2012-02-23 20:27 ` Benjamin Herrenschmidt
2012-02-23 20:25 ` Benjamin Herrenschmidt
2012-02-24 16:22 ` Arnd Bergmann
2012-02-24 21:03 ` Benjamin Herrenschmidt
2012-02-23 12:01 ` Stefan Roese
2012-02-24 4:22 ` Pratyush Anand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223113801.GV22562@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).