From: mporter@ti.com (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators
Date: Thu, 23 Feb 2012 09:26:13 -0500 [thread overview]
Message-ID: <20120223142612.GA13407@beef> (raw)
In-Reply-To: <79CD15C6BA57404B839C016229A409A8317DA6CD@DBDE01.ent.ti.com>
On Thu, Feb 23, 2012 at 12:08:34PM +0000, Hiremath, Vaibhav wrote:
> On Wed, Feb 22, 2012 at 22:15:03, Porter, Matt wrote:
> > /*
> > * Initialize smsc911x device connected to the GPMC. Note that we
> > * assume that pin multiplexing is done in the board-*.c file,
> > @@ -51,10 +97,16 @@ void __init gpmc_smsc911x_init(struct omap_smsc911x_platform_data *board_data)
> > {
> > struct platform_device *pdev;
> > unsigned long cs_mem_base;
> > - int ret;
> > + int ret, err;
> >
>
> Do you really need another variable here? Can't you use "ret" here?
No we don't, thanks for catching this. I posted a v3 that addresses it.
Tony: can you revert v2 for v3 that I just posted which addresses
Vaibhav's comment?
-Matt
prev parent reply other threads:[~2012-02-23 14:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-22 16:45 [PATCH v2] ARM: OMAP2+: gpmc-smsc911x: add required smsc911x regulators Matt Porter
2012-02-22 23:10 ` Tony Lindgren
2012-02-23 12:08 ` Hiremath, Vaibhav
2012-02-23 14:26 ` Matt Porter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120223142612.GA13407@beef \
--to=mporter@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).