From: heiko@sntech.de (Heiko Stübner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] S3C24XX DMA resume regression fix
Date: Fri, 24 Feb 2012 14:17:24 +0100 [thread overview]
Message-ID: <201202241417.24652.heiko@sntech.de> (raw)
In-Reply-To: <1330087227-10450-1-git-send-email-dron0gus@gmail.com>
Am Freitag, 24. Februar 2012, 13:40:27 schrieb Gusakov Andrey:
> s3c2410_dma_suspend suspends channels from 0 to dma_channels.
> s3c2410_dma_resume resumes channels in reverse order. So
> pointer should be decremented insted of being incremented.
> ---
> arch/arm/plat-s3c24xx/dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/plat-s3c24xx/dma.c b/arch/arm/plat-s3c24xx/dma.c
> index 57abec9..16510d5 100644
> --- a/arch/arm/plat-s3c24xx/dma.c
> +++ b/arch/arm/plat-s3c24xx/dma.c
> @@ -1249,7 +1249,7 @@ static void s3c2410_dma_resume(void)
> struct s3c2410_dma_chan *cp = s3c2410_chans + dma_channels - 1;
> int channel;
>
> - for (channel = dma_channels - 1; channel >= 0; cp++, channel--)
> + for (channel = dma_channels - 1; channel >= 0; cp--, channel--)
> s3c2410_dma_resume_chan(cp);
> }
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
it's interesting, that this is broken since april 2011, so I guess it's time
to fix it :-)
next prev parent reply other threads:[~2012-02-24 13:17 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-24 12:40 [PATCH v3] S3C24XX DMA resume regression fix Gusakov Andrey
2012-02-24 13:17 ` Heiko Stübner [this message]
2012-03-01 4:26 ` Kukjin Kim
2012-03-01 4:55 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201202241417.24652.heiko@sntech.de \
--to=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox