From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for platform_cpu_die()
Date: Tue, 28 Feb 2012 14:34:48 -0800 [thread overview]
Message-ID: <20120228223447.GE18901@atomide.com> (raw)
In-Reply-To: <CAMQu2gxLJOY8HzMO71dHTr8VfQ+G=KJP+wv5SwvrktTi7b82+A@mail.gmail.com>
* Shilimkar, Santosh <santosh.shilimkar@ti.com> [120223 00:09]:
> 2012/2/23 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> > Hello,
> >
> > On Thu, Feb 23, 2012 at 12:28:30PM +0530, Santosh Shilimkar wrote:
> >> WARNING: vmlinux.o(.text+0x226d0):
> >> Section mismatch in reference from the function
> >> platform_cpu_die() to the function .cpuinit.text:omap4_hotplug_cpu()
> >> The function platform_cpu_die() references
> >> the function __cpuinit omap4_hotplug_cpu().
> >> This is often because platform_cpu_die lacks a __cpuinit
> >> annotation or the annotation of omap4_hotplug_cpu is wrong.
> >>
> >> Thanks to Russell King for suggesting __ref annotation trick
> >> just like it's parent function for this warning becasue __cupinit
> > s/it's/its/; s/becasue/because/; s/cup/cpu/
> >
> > Having said that I think the grammar is broken, too. Maybe:
> >
> > ? ? ? ?Thanks to Russell King for suggesting to use __ref instead of
> > ? ? ? ?the initial (and wrong) approach to use __cpuinit.
> >
> > (But note I'm not a native speaker, too)
> >
> Thanks for fixing the grammar. :)
> Updated patch below with comments corrected as per
> your suggestion.
Thanks applying both into fixes-non-critical.
Regards,
Tony
prev parent reply other threads:[~2012-02-28 22:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 6:58 [PATCH 0/2] OMAP: Section mismatch warning fixes Santosh Shilimkar
2012-02-23 6:58 ` [PATCH 1/2] ARM: OMAP: fix section mismatch warning for omap4_hotplug_cpu() Santosh Shilimkar
2012-02-23 6:58 ` [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for platform_cpu_die() Santosh Shilimkar
2012-02-23 7:45 ` Uwe Kleine-König
2012-02-23 8:40 ` Shilimkar, Santosh
2012-02-28 22:34 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120228223447.GE18901@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).