* [PATCH 0/2] OMAP: Section mismatch warning fixes
@ 2012-02-23 6:58 Santosh Shilimkar
2012-02-23 6:58 ` [PATCH 1/2] ARM: OMAP: fix section mismatch warning for omap4_hotplug_cpu() Santosh Shilimkar
2012-02-23 6:58 ` [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for platform_cpu_die() Santosh Shilimkar
0 siblings, 2 replies; 6+ messages in thread
From: Santosh Shilimkar @ 2012-02-23 6:58 UTC (permalink / raw)
To: linux-arm-kernel
Tony,
Below are couple of section mismatch warning fixes for v3.3-rc5
Santosh Shilimkar (2):
ARM: OMAP: fix section mismatch warning for omap4_hotplug_cpu()
ARM: OMAP: Fix section mismatch warning for platform_cpu_die()
arch/arm/mach-omap2/omap-hotplug.c | 2 +-
arch/arm/mach-omap2/omap-mpuss-lowpower.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
1.7.4.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] ARM: OMAP: fix section mismatch warning for omap4_hotplug_cpu()
2012-02-23 6:58 [PATCH 0/2] OMAP: Section mismatch warning fixes Santosh Shilimkar
@ 2012-02-23 6:58 ` Santosh Shilimkar
2012-02-23 6:58 ` [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for platform_cpu_die() Santosh Shilimkar
1 sibling, 0 replies; 6+ messages in thread
From: Santosh Shilimkar @ 2012-02-23 6:58 UTC (permalink / raw)
To: linux-arm-kernel
WARNING: arch/arm/mach-omap2/built-in.o(.text+0x8b80):
Section mismatch in reference from the function omap4_hotplug_cpu() to
the function .cpuinit.text:omap_secondary_startup()
The function omap4_hotplug_cpu() references
the function __cpuinit omap_secondary_startup().
This is often because omap4_hotplug_cpu lacks a __cpuinit
annotation or the annotation of omap_secondary_startup is wrong.
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
arch/arm/mach-omap2/omap-mpuss-lowpower.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap-mpuss-lowpower.c b/arch/arm/mach-omap2/omap-mpuss-lowpower.c
index 1d5d010..fe9ab7c 100644
--- a/arch/arm/mach-omap2/omap-mpuss-lowpower.c
+++ b/arch/arm/mach-omap2/omap-mpuss-lowpower.c
@@ -300,7 +300,7 @@ int omap4_enter_lowpower(unsigned int cpu, unsigned int power_state)
* @cpu : CPU ID
* @power_state: CPU low power state.
*/
-int omap4_hotplug_cpu(unsigned int cpu, unsigned int power_state)
+int __cpuinit omap4_hotplug_cpu(unsigned int cpu, unsigned int power_state)
{
unsigned int cpu_state = 0;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for platform_cpu_die()
2012-02-23 6:58 [PATCH 0/2] OMAP: Section mismatch warning fixes Santosh Shilimkar
2012-02-23 6:58 ` [PATCH 1/2] ARM: OMAP: fix section mismatch warning for omap4_hotplug_cpu() Santosh Shilimkar
@ 2012-02-23 6:58 ` Santosh Shilimkar
2012-02-23 7:45 ` Uwe Kleine-König
1 sibling, 1 reply; 6+ messages in thread
From: Santosh Shilimkar @ 2012-02-23 6:58 UTC (permalink / raw)
To: linux-arm-kernel
WARNING: vmlinux.o(.text+0x226d0):
Section mismatch in reference from the function
platform_cpu_die() to the function .cpuinit.text:omap4_hotplug_cpu()
The function platform_cpu_die() references
the function __cpuinit omap4_hotplug_cpu().
This is often because platform_cpu_die lacks a __cpuinit
annotation or the annotation of omap4_hotplug_cpu is wrong.
Thanks to Russell King for suggesting __ref annotation trick
just like it's parent function for this warning becasue __cupinit
usage was definitely wrong to fix this warning..
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
arch/arm/mach-omap2/omap-hotplug.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap-hotplug.c b/arch/arm/mach-omap2/omap-hotplug.c
index adbe4d8..56c345b 100644
--- a/arch/arm/mach-omap2/omap-hotplug.c
+++ b/arch/arm/mach-omap2/omap-hotplug.c
@@ -33,7 +33,7 @@ int platform_cpu_kill(unsigned int cpu)
* platform-specific code to shutdown a CPU
* Called with IRQs disabled
*/
-void platform_cpu_die(unsigned int cpu)
+void __ref platform_cpu_die(unsigned int cpu)
{
unsigned int this_cpu;
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for platform_cpu_die()
2012-02-23 6:58 ` [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for platform_cpu_die() Santosh Shilimkar
@ 2012-02-23 7:45 ` Uwe Kleine-König
2012-02-23 8:40 ` Shilimkar, Santosh
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2012-02-23 7:45 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Thu, Feb 23, 2012 at 12:28:30PM +0530, Santosh Shilimkar wrote:
> WARNING: vmlinux.o(.text+0x226d0):
> Section mismatch in reference from the function
> platform_cpu_die() to the function .cpuinit.text:omap4_hotplug_cpu()
> The function platform_cpu_die() references
> the function __cpuinit omap4_hotplug_cpu().
> This is often because platform_cpu_die lacks a __cpuinit
> annotation or the annotation of omap4_hotplug_cpu is wrong.
>
> Thanks to Russell King for suggesting __ref annotation trick
> just like it's parent function for this warning becasue __cupinit
s/it's/its/; s/becasue/because/; s/cup/cpu/
Having said that I think the grammar is broken, too. Maybe:
Thanks to Russell King for suggesting to use __ref instead of
the initial (and wrong) approach to use __cpuinit.
(But note I'm not a native speaker, too)
Uwe
> usage was definitely wrong to fix this warning..
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for platform_cpu_die()
2012-02-23 7:45 ` Uwe Kleine-König
@ 2012-02-23 8:40 ` Shilimkar, Santosh
2012-02-28 22:34 ` Tony Lindgren
0 siblings, 1 reply; 6+ messages in thread
From: Shilimkar, Santosh @ 2012-02-23 8:40 UTC (permalink / raw)
To: linux-arm-kernel
2012/2/23 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> Hello,
>
> On Thu, Feb 23, 2012 at 12:28:30PM +0530, Santosh Shilimkar wrote:
>> WARNING: vmlinux.o(.text+0x226d0):
>> Section mismatch in reference from the function
>> platform_cpu_die() to the function .cpuinit.text:omap4_hotplug_cpu()
>> The function platform_cpu_die() references
>> the function __cpuinit omap4_hotplug_cpu().
>> This is often because platform_cpu_die lacks a __cpuinit
>> annotation or the annotation of omap4_hotplug_cpu is wrong.
>>
>> Thanks to Russell King for suggesting __ref annotation trick
>> just like it's parent function for this warning becasue __cupinit
> s/it's/its/; s/becasue/because/; s/cup/cpu/
>
> Having said that I think the grammar is broken, too. Maybe:
>
> ? ? ? ?Thanks to Russell King for suggesting to use __ref instead of
> ? ? ? ?the initial (and wrong) approach to use __cpuinit.
>
> (But note I'm not a native speaker, too)
>
Thanks for fixing the grammar. :)
Updated patch below with comments corrected as per
your suggestion.
Regards
Santosh
>From a53dd2d822dc9c9894c2f2f3d239af341c66d891 Mon Sep 17 00:00:00 2001
From: Santosh Shilimkar <santosh.shilimkar@ti.com>
Date: Wed, 22 Feb 2012 16:10:04 +0530
Subject: [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for
platform_cpu_die()
WARNING: vmlinux.o(.text+0x226d0):
Section mismatch in reference from the function
platform_cpu_die() to the function .cpuinit.text:omap4_hotplug_cpu()
The function platform_cpu_die() references
the function __cpuinit omap4_hotplug_cpu().
This is often because platform_cpu_die lacks a __cpuinit
annotation or the annotation of omap4_hotplug_cpu is wrong.
Thanks to Russell King for suggesting to use __ref instead of
the initial (and wrong) approach to use __cpuinit.
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
---
arch/arm/mach-omap2/omap-hotplug.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/omap-hotplug.c
b/arch/arm/mach-omap2/omap-hotplug.c
index adbe4d8..56c345b 100644
--- a/arch/arm/mach-omap2/omap-hotplug.c
+++ b/arch/arm/mach-omap2/omap-hotplug.c
@@ -33,7 +33,7 @@ int platform_cpu_kill(unsigned int cpu)
* platform-specific code to shutdown a CPU
* Called with IRQs disabled
*/
-void platform_cpu_die(unsigned int cpu)
+void __ref platform_cpu_die(unsigned int cpu)
{
unsigned int this_cpu;
--
1.7.4.1
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-ARM-OMAP-Fix-section-mismatch-warning-for-platform_c.patch
Type: application/octet-stream
Size: 1343 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20120223/148fa317/attachment.obj>
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for platform_cpu_die()
2012-02-23 8:40 ` Shilimkar, Santosh
@ 2012-02-28 22:34 ` Tony Lindgren
0 siblings, 0 replies; 6+ messages in thread
From: Tony Lindgren @ 2012-02-28 22:34 UTC (permalink / raw)
To: linux-arm-kernel
* Shilimkar, Santosh <santosh.shilimkar@ti.com> [120223 00:09]:
> 2012/2/23 Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>:
> > Hello,
> >
> > On Thu, Feb 23, 2012 at 12:28:30PM +0530, Santosh Shilimkar wrote:
> >> WARNING: vmlinux.o(.text+0x226d0):
> >> Section mismatch in reference from the function
> >> platform_cpu_die() to the function .cpuinit.text:omap4_hotplug_cpu()
> >> The function platform_cpu_die() references
> >> the function __cpuinit omap4_hotplug_cpu().
> >> This is often because platform_cpu_die lacks a __cpuinit
> >> annotation or the annotation of omap4_hotplug_cpu is wrong.
> >>
> >> Thanks to Russell King for suggesting __ref annotation trick
> >> just like it's parent function for this warning becasue __cupinit
> > s/it's/its/; s/becasue/because/; s/cup/cpu/
> >
> > Having said that I think the grammar is broken, too. Maybe:
> >
> > ? ? ? ?Thanks to Russell King for suggesting to use __ref instead of
> > ? ? ? ?the initial (and wrong) approach to use __cpuinit.
> >
> > (But note I'm not a native speaker, too)
> >
> Thanks for fixing the grammar. :)
> Updated patch below with comments corrected as per
> your suggestion.
Thanks applying both into fixes-non-critical.
Regards,
Tony
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-02-28 22:34 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-23 6:58 [PATCH 0/2] OMAP: Section mismatch warning fixes Santosh Shilimkar
2012-02-23 6:58 ` [PATCH 1/2] ARM: OMAP: fix section mismatch warning for omap4_hotplug_cpu() Santosh Shilimkar
2012-02-23 6:58 ` [PATCH 2/2] ARM: OMAP: Fix section mismatch warning for platform_cpu_die() Santosh Shilimkar
2012-02-23 7:45 ` Uwe Kleine-König
2012-02-23 8:40 ` Shilimkar, Santosh
2012-02-28 22:34 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).