[PATCH] ARM: 3ds_debugboard: Let ethernet be functional again

[s.hauer@pengutronix.de (Sascha Hauer)]

On Tue, Feb 28, 2012 at 10:52:22AM +0000, Mark Brown wrote:
> On Tue, Feb 28, 2012 at 09:27:15AM +0100, Sascha Hauer wrote:
> > On Mon, Feb 27, 2012 at 11:54:00PM +0000, Mark Brown wrote:
> 
> > > No, zero is intentionally a valid response - it means that the selector
> > > is invalid (for example, due to being documented as a reserved value)
> > > allowing a non-error return that doesn't provide a voltage.  The fixed
> > > regulator should be fixed to return an error if it hasn't got a voltage
> > > configured.
> 
> > Hm, you asked me to drop the voltage parameter from the helper function
> > registering a fixed regulator as dummy. When the fixed regulator bails
> > out in this case I can't see how this can be done.
> 
> Can you be more specific about what you think would break here please?

We started this discussion with a patch of mine in which I wanted to add
a helper function to register a fixed regulator. You asked me to drop
the voltage parameter in the helper function as this is mainly used as
a dummy regulator. I then tried to remove the voltage parameter and it
turned out that the regulator core needs a voltage because otherwise it
bails out in machine_constraints_voltage(), more specifically in
ops->list_voltage(rdev, i) returing 0 for a dummy fixed regulator. You
then answered that the fixed regulator should be fixed to return an error
if it hasn't got a voltage configured. At this point the circle is
complete and we can start the discussion again.

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |