From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: id: Add missing break statement in omap3xxx_check_revision
Date: Wed, 29 Feb 2012 14:42:50 -0800 [thread overview]
Message-ID: <20120229224250.GT18901@atomide.com> (raw)
In-Reply-To: <79CD15C6BA57404B839C016229A409A8317B7282@DBDE01.ent.ti.com>
* Hiremath, Vaibhav <hvaibhav@ti.com> [120129 23:59]:
> On Fri, Jan 27, 2012 at 11:02:01, Hiremath, Vaibhav wrote:
> > On Fri, Jan 27, 2012 at 05:55:43, Tony Lindgren wrote:
> > > * Vaibhav Hiremath <hvaibhav@ti.com> [120122 23:26]:
> > > > Add missing break statement in the function omap3xxx_check_revision.
> > > >
> > > > The commit id 4390f5b2cb1f56 [ARM: OMAP: TI814X: Add cpu type macros
> > > > and detection support], removed the 'break' statement from the function
> > > > omap3xxx_check_revision(), resulting into wrong omap/cpu_revision
> > > > initialization for AM335x devices.
> > >
> > > Looks like this is already fixed, can you please verify with
> > > v3.3-rc1?
> > >
> > Tony,
> >
> > I just looked at your linux-omap/master branch and 'break' statement is missing. So this patch is still required.
> >
> > I can still see,
> >
> > 394 }
> > 395 break;
> > 396 case 0xb944:
> > 397 omap_revision = AM335X_REV_ES1_0;
> > 398 cpu_rev = "1.0";
> > 399 case 0xb8f2:
> > 400 switch (rev) {
> >
> >
> Tony,
>
> Can this be merged? I can still see "break" statement missing in the latest
> linux-omap/master branch.
OK thanks applying into fixes for the -rc cycle.
Tony
prev parent reply other threads:[~2012-02-29 22:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-23 7:56 [PATCH] ARM: OMAP: id: Add missing break statement in omap3xxx_check_revision Vaibhav Hiremath
2012-01-27 0:25 ` Tony Lindgren
2012-01-27 5:32 ` Hiremath, Vaibhav
2012-01-30 8:30 ` Hiremath, Vaibhav
2012-02-29 22:42 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120229224250.GT18901@atomide.com \
--to=tony@atomide.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).