linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 19/28] ARM: Add fixed PCI i/o mapping
Date: Wed, 29 Feb 2012 22:43:13 +0000	[thread overview]
Message-ID: <201202292243.13923.arnd@arndb.de> (raw)
In-Reply-To: <4F4EA694.5060003@gmail.com>

On Wednesday 29 February 2012, Rob Herring wrote:
> No, then the mapping will fail. I do need to double check all the
> mappings and make sure there is no overlap but we only care on the PCI
> platforms I converted.
> 
> Also, it should be noted this shrinks the i/o space on some platforms.
> dove and kirkwood had 1MB x 2 buses and now have 64KB per bus. ixp2000 I
> think has 32MB with a note saying they need "a lot". Is there really a
> use for lots of i/o space?

Given that each PCI bus only wires up the lower 64k, I'd say no ;-)

My guess is that they used 1MB ranges in order to benefit from section
mapping. In case of ixp2000, I only see 64k in the resource:

static struct resource ixp2000_pci_io_space = {
        .start  = 0x00010000,
        .end    = 0x0001ffff,
        .flags  = IORESOURCE_IO,
        .name   = "PCI I/O Space"
};

The part that I don't understand here is why the resource starts at
64k and is another 64k in size. I think we need to double-check this
in order to be sure whether we have to put the pci io space into the
first or the second 64k chunk of the new mapping area.

Hmm, I guess you meant ixp23xx, not ixp2000, which indeed has

static struct resource ixp23xx_pci_io_space = {
        .start  = 0x00000100,
        .end    = 0x01ffffff,
        .flags  = IORESOURCE_IO,
        .name   = "PCI I/O Space"
};

This seems to be done just for simplicity in the implementation,
to keep all parts of the PCI controller 32MB aligned, I can't
see any real technical reason why it would be useful othewise.

	Arnd

  reply	other threads:[~2012-02-29 22:43 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1330547147-22867-1-git-send-email-robherring2@gmail.com>
     [not found] ` <1330547147-22867-17-git-send-email-robherring2@gmail.com>
2012-02-29 20:40   ` [PATCH v2 16/28] ARM: remove bunch of now unused mach/io.h files H Hartley Sweeten
     [not found] ` <1330547147-22867-16-git-send-email-robherring2@gmail.com>
2012-02-29 20:43   ` [PATCH v2 15/28] ARM: make mach/io.h include optional H Hartley Sweeten
     [not found] ` <1330547147-22867-8-git-send-email-robherring2@gmail.com>
     [not found]   ` <201202292147.39302.arnd@arndb.de>
2012-02-29 22:16     ` [PATCH v2 07/28] ARM: iop13xx: move io.h externs to io.c Rob Herring
2012-02-29 22:26       ` Arnd Bergmann
     [not found] ` <1330547147-22867-4-git-send-email-robherring2@gmail.com>
     [not found]   ` <201202292134.03220.arnd@arndb.de>
2012-02-29 22:55     ` [PATCH v2 03/28] ARM: imx: convert to common runtime ioremap hook Rob Herring
2012-02-29 23:13       ` Arnd Bergmann
     [not found] ` <1330547147-22867-20-git-send-email-robherring2@gmail.com>
     [not found]   ` <201202292153.03056.arnd@arndb.de>
2012-02-29 22:28     ` [PATCH v2 19/28] ARM: Add fixed PCI i/o mapping Rob Herring
2012-02-29 22:43       ` Arnd Bergmann [this message]
2012-02-29 23:21         ` Russell King - ARM Linux
2012-03-01 13:52           ` Arnd Bergmann
2012-03-01 14:08             ` Russell King - ARM Linux
2012-03-01 18:25               ` Arnd Bergmann
2012-03-01 20:32                 ` Andrew Lunn
2012-03-05 20:24                 ` Nicolas Pitre
     [not found]   ` <20120229221341.GF16999@n2100.arm.linux.org.uk>
2012-03-01  4:11     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=201202292243.13923.arnd@arndb.de \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).